Add draft 2.0 release notes.

Review Request #5717 — Created April 16, 2014 and submitted

Information

Review Board
release-2.0.x
482af8c...

Reviewers

This has everything from the 2.0 beta 1, beta 2, beta 3, RC 1, and RC 2
releases, plus the changes that have gone in since RC 2, minus the changes and
bugfixes that have been backported to 1.7.x, and minus any fixes from later
prereleases for features introduced in earlier prereleases.

  • Built HTML and read through it.
  • Did some fancy-pants grepping to check for backported bugs.
Description From Last Updated

We should add the "patch by" to this too.

chipx86chipx86

Something's wrong with this sentence.

chipx86chipx86

This first sentence feels a bit awkward too. The interface doesn't just change when there are multiple revisions. Maybe just …

chipx86chipx86

"review request" is used everywhere else, so we should use that instead of "Review Request." Worth grepping to see if …

chipx86chipx86

I had to read this three times. We should simplify it, get straight to the heart of the problem: "Interdiffs …

chipx86chipx86

Why the extra spaces after the *?

chipx86chipx86

I read the "committed changes from .." at first as the source of the commits coming from some place. Maybe …

chipx86chipx86

"review request"

chipx86chipx86

Maybe "formatting" instead of "rich features"?

chipx86chipx86

Would be nice to link to these features.

chipx86chipx86

Let's link to the user manual page for this.

chipx86chipx86

"of the text" ?

chipx86chipx86

We should probably use :guilabel: for Review and New Comment.

chipx86chipx86

We may also want to use :guilabel: for all these. We have various places in the release notes where we're …

chipx86chipx86

:guilabel: for Show Changes

chipx86chipx86

Missing period.

chipx86chipx86

:guilabel: here too?

chipx86chipx86

"pencil"

chipx86chipx86

This is a big enough one where it should probably get its own section.

chipx86chipx86

:guilabel: for "System Information"?

chipx86chipx86

:guilabel:

chipx86chipx86

:guilabel:?

chipx86chipx86

Does this wrapped link work? I thought there were issues with that.

chipx86chipx86

Same question about these wrapped links.

chipx86chipx86

Too many blank lines.

chipx86chipx86

We shouldn't need this section.

chipx86chipx86

Let's move the "Patch by ..." to a next paragraph.

chipx86chipx86

Should put `\`` aroundissue_opened`.

chipx86chipx86

Should also put the quotes around open and null.

chipx86chipx86

Too many blank lines.

chipx86chipx86

Too many blank lines.

chipx86chipx86

We should link to the proper place. "See below" doesn't apply anymore.

chipx86chipx86

This is a big enough one where we should probably just give it its own section under Extensions.

chipx86chipx86

This is just one of many things that center around auth backends. We should give those their own section.

chipx86chipx86

"JavaScript"

chipx86chipx86

We should probably make the wording more consistent, since these are saying the same things but for two different types …

chipx86chipx86

I think these should always be the first section.

chipx86chipx86

Didn't we fix this in a 1.7.x?

chipx86chipx86

We should link to the 1.6 docs now.

chipx86chipx86

This should probably be after New Features, I think?

chipx86chipx86

This should be removed.

chipx86chipx86

I think this was just part of the whole new move detection stuff. I don't think we need this in …

chipx86chipx86

This was part of the new move detection stuff. This can be removed.

chipx86chipx86

This was part of the new interdiff code. This can be removed.

chipx86chipx86

Also part of the new interdiff code. Can also be removed.

chipx86chipx86

Part of the new move detection code. Can be removed.

chipx86chipx86

Can also be removed.

chipx86chipx86

I think this is covered by the "New Feature" entry.

chipx86chipx86

These are all things that were introduced in 2.0. We can remove these as well.

chipx86chipx86

2.0 betas. This can be removed.

chipx86chipx86

Introduced in 2.0. This can be removed.

chipx86chipx86

I think this was a regression in the new JS code. I think we can remove this.

chipx86chipx86

Introduced in 2.0. Can be removed.

chipx86chipx86

All stuff from 2.0. These can be removed.

chipx86chipx86

All bugs introduced in 2.0. These can be removed.

chipx86chipx86

This was a regression with the new My Account page. This can be removed.

chipx86chipx86

This is in 1.7.23. We can remove this.

chipx86chipx86

Wasn't this fixed in a 1.7.x?

chipx86chipx86

Introduced in 2.0. Can be removed.

chipx86chipx86

Introduced in 2.0. Can be removed.

chipx86chipx86

Regression in 2.0, from the Django upgrade. Can be removed.

chipx86chipx86
chipx86
  1. A lot of this is from older release notes, probably, but I noticed some things we could be more consistent with.

    There's also a handful of bugs that were introduced in 2.0, and can be removed.

  2. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
    Show all issues

    We should add the "patch by" to this too.

  3. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
    Show all issues

    Something's wrong with this sentence.

    1. This was copied from the old one, so I'm blaming you :)

    2. I will take the blame for a lot of these. I'm sure many are my fault :)

  4. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
     
     
    Show all issues

    This first sentence feels a bit awkward too. The interface doesn't just change when there are multiple revisions. Maybe just something like:

    "The interface for choosing which diff revision or set of interdiff revisions to view has changed."

    I don't think we need to mention the "multiple revisions of a diff," since our users who are reading release notes are probably familiar with that.

  5. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
    Show all issues

    "review request" is used everywhere else, so we should use that instead of "Review Request."

    Worth grepping to see if there are more occurrences.

  6. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
     
     
    Show all issues

    I had to read this three times. We should simplify it, get straight to the heart of the problem:

    "Interdiffs could become a mess after syncing a development tree and posting a new diff. They would show changes from the sync that were unrelated to the posted change.

    The diff viewer will now do its best ..."

  7. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
     
    Show all issues

    Why the extra spaces after the *?

  8. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
    Show all issues

    I read the "committed changes from .." at first as the source of the commits coming from some place. Maybe "of the committed changes, ordered from most recent to least." ?

  9. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
     

    Did we get any changes landed recently to expand this?

    1. No. Those are in some of Olessia's pending changes.

  10. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
    Show all issues

    "review request"

  11. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
    Show all issues

    Maybe "formatting" instead of "rich features"?

  12. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
    Show all issues

    Would be nice to link to these features.

    1. I'm just going to link to our "using markdown" page for this and the comment below.

  13. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
    Show all issues

    Let's link to the user manual page for this.

  14. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
    Show all issues

    "of the text" ?

  15. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
     
    Show all issues

    We should probably use :guilabel: for Review and New Comment.

  16. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
    Show all issues

    We may also want to use :guilabel: for all these. We have various places in the release notes where we're inconsistent here. We alternate between things like description, Description, and :guillabel:\Description``. We should try to make these all consistent.

    In the past, I've tried to use :guilabel: for these (though I'm sure I've missed some on occasion).

  17. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
    Show all issues

    :guilabel: for Show Changes

  18. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
    Show all issues

    Missing period.

  19. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
    Show all issues

    :guilabel: here too?

  20. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
    Show all issues

    "pencil"

  21. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
    Show all issues

    This is a big enough one where it should probably get its own section.

  22. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
    Show all issues

    :guilabel: for "System Information"?

  23. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
    Show all issues

    :guilabel:

  24. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
    Show all issues

    :guilabel:?

  25. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
     
    Show all issues

    Does this wrapped link work? I thought there were issues with that.

  26. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
     
     
     
    Show all issues

    Same question about these wrapped links.

  27. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
     
     
     
    Show all issues

    Too many blank lines.

  28. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
    Show all issues

    We shouldn't need this section.

  29. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
    Show all issues

    Let's move the "Patch by ..." to a next paragraph.

  30. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
    Show all issues

    Should put `\`` aroundissue_opened`.

  31. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
    Show all issues

    Should also put the quotes around open and null.

  32. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
     
     
     
     
    Show all issues

    Too many blank lines.

  33. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
     
     
     
     
    Show all issues

    Too many blank lines.

  34. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
    Show all issues

    We should link to the proper place. "See below" doesn't apply anymore.

  35. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
    Show all issues

    This is a big enough one where we should probably just give it its own section under Extensions.

    1. Really? I don't really think it's going to be used very much at all...

    2. Hmm, fair enough. I guess it's more important when working with third-party templates/views that require context processors, but not so much for completely custom extensions.

  36. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
    Show all issues

    This is just one of many things that center around auth backends. We should give those their own section.

  37. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
    Show all issues

    "JavaScript"

  38. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
     
     
     
    Show all issues

    We should probably make the wording more consistent, since these are saying the same things but for two different types of objects.

  39. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
     
    Show all issues

    I think these should always be the first section.

  40. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
    Show all issues

    Didn't we fix this in a 1.7.x?

  41. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
    Show all issues

    We should link to the 1.6 docs now.

  42. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
     
    Show all issues

    This should probably be after New Features, I think?

  43. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
    Show all issues

    This should be removed.

  44. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
     
    Show all issues

    I think this was just part of the whole new move detection stuff. I don't think we need this in bugs.

  45. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
    Show all issues

    This was part of the new move detection stuff. This can be removed.

  46. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
     
    Show all issues

    This was part of the new interdiff code. This can be removed.

  47. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
    Show all issues

    Also part of the new interdiff code. Can also be removed.

  48. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
    Show all issues

    Part of the new move detection code. Can be removed.

  49. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
     
    Show all issues

    Can also be removed.

  50. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
    Show all issues

    I think this is covered by the "New Feature" entry.

  51. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
    Show all issues

    These are all things that were introduced in 2.0. We can remove these as well.

  52. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
     
    Show all issues

    2.0 betas. This can be removed.

  53. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
     
    Show all issues

    Introduced in 2.0. This can be removed.

  54. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
    Show all issues

    I think this was a regression in the new JS code. I think we can remove this.

  55. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
    Show all issues

    Introduced in 2.0. Can be removed.

  56. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
    Show all issues

    All stuff from 2.0. These can be removed.

  57. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
     
     
     
     
     
     
     
    Show all issues

    All bugs introduced in 2.0. These can be removed.

  58. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
    Show all issues

    This was a regression with the new My Account page. This can be removed.

  59. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
    Show all issues

    This is in 1.7.23. We can remove this.

  60. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
     
    Show all issues

    Wasn't this fixed in a 1.7.x?

  61. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
    Show all issues

    Introduced in 2.0. Can be removed.

  62. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
    Show all issues

    Introduced in 2.0. Can be removed.

  63. docs/releasenotes/2.0.rst (Diff revision 1)
     
     
    Show all issues

    Regression in 2.0, from the Django upgrade. Can be removed.

  64. 
      
david
chipx86
  1. Ship It!

  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (1951a3c)
Loading...