Adding sandboxing to action_hooks

Review Request #5710 — Created April 13, 2014 and submitted

Information

Review Board
master

Reviewers

Added sandboxing to action_hooks

Added unit tests to test suites at reviewboard/extensions/tests.py

Unit testing done - tested all 5 different action hooks (DiffViewerActionHook, HeaderActionHook, HeaderDropdownActionHook, ReivewRequestActionHook, ReviewRequestDropdownActionHook) with and without the sandboxing

Ran on all tests in extensions/tests.py

Description From Last Updated

Pleane remove the space at the end of this string.

daviddavid

This could be rewrapped a bit. In particular, it would be nice to have "%s.get_actions" together.

daviddavid

Do you need to modify this test to instantiate ReviewRequestApprovalTestHook now that you've removed that from SandboxExtension?

daviddavid

I think you should remove this and instead instantiate the ReviewRequestApprovalTestHook inside the test_is_approved_sandbox method (like you do for all …

daviddavid
david
  1. 
      
  2. Pleane remove the space at the end of this string.

  3. 
      
ED
david
  1. This patch no longer applies cleanly. Can you rebase this onto the latest release-2.0.x and update?

  2. This could be rewrapped a bit. In particular, it would be nice to have "%s.get_actions" together.

  3. 
      
ED
david
  1. 
      
  2. reviewboard/extensions/tests.py (Diff revision 3)
     
     
     

    Do you need to modify this test to instantiate ReviewRequestApprovalTestHook now that you've removed that from SandboxExtension?

  3. Can you run all the unit tests, not just the newly-added ones?

ED
ED
david
  1. 
      
  2. reviewboard/extensions/tests.py (Diff revision 4)
     
     

    I think you should remove this and instead instantiate the ReviewRequestApprovalTestHook inside the test_is_approved_sandbox method (like you do for all of these new test hooks that you've introduced).

  3. 
      
ED
david
  1. Ship It!

  2. 
      
ED
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (6b0ec1c)
Loading...