• 
      

    Fix the state of our JavaScript unit tests.

    Review Request #5700 — Created April 11, 2014 and submitted

    Information

    Review Board
    release-2.0.x
    ec18497...

    Reviewers

    Our unit tests have regressed a bit recently, for a few reasons.

    First, we were still trying to run the old configForms code, which
    shouldn't have remained in the codebase. This has now been deleted, and
    the new djblets-js-tests bundle has been loaded in to run the proper
    configForms test suite.

    Second, the recent addition to confirm the Discard Review Request action
    resulted in the confirmation dialog appearing during the test run. We
    now spy on window.confirm and provide a proper result in order to
    prevent this.

    Unit tests pass.

    david
    1. Ship It!

    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.0.x (23ec2b0)