Summary:

Beanstalk post-receive web hook

Review Request #5698 — Created April 10, 2014 and submitted April 23, 2014, 1:58 p.m.

Information
Owner:	b.ramnani
Repository:	Review Board
Branch:	master
Bugs:
Depends On:
Commit:	b77457d...
Reviewers
Groups:	reviewboard
People:	chipx86, david, mike_conley, smacleod

Description

This is a Beanstalk post-receive hook that will automatically close review requests as "submitted" after a push. To determine which review requests should be closed, it scans through each commit's commit message for the following strings (case-insensitive): "Reviewed at <reviewboard_url>/r/<id>" or "Review request #<id>".

This is what the JSON payload looks like:
http://support.beanstalkapp.com/customer/portal/articles/75753-trigger-a-url-on-commit-with-web-hooks

Testing Done

Test carried out on git and svn repos.
1) Push with the review request id in the commit message. Review request closed. [PASSED]

2) Push without a review request id in the commit message. (Review request closed based on the commit_id for git and error looged for svn) [PASSED].

3) Push with non existent review request id. (Error: Review request does not exist) [PASSED]

4) Push with review id in the message that is already submitted. (logged a warning: request id already submitted.) [PASSED]

5) Push with review id in the message that has been marked as discarded. (review request marked as submitted.) [PASSED]

Issues

Description	From	Last Updated
Remove this line.	david	April 22, 2014, 12:56 a.m.
Remove this line.	david	April 22, 2014, 12:56 a.m.
We've switched over to using the new exception syntax: try: ... except KeyError as e: ...	david	April 22, 2014, 12:56 a.m.
We've switched over to using the new exception syntax: try: ... except KeyError as e: ...	david	April 22, 2014, 12:56 a.m.
How would you feel about introducing another method that could do this check and fan out to the individual implementations?	david	April 22, 2014, 12:40 a.m.
So the individual implementations close the review requests or they just return the review_id_to_commits map as they do now ?	B. b.ramnani	April 22, 2014, 12:40 a.m.
dict.get() defaults to None if the key doesn't exist, so you don't need to specify this second parameter.	david	April 22, 2014, 12:41 a.m.
Two blank lines between top-level things.	david	April 22, 2014, 12:58 a.m.
Can you try to shorten and/or re-wrap this to keep it under 80 columns?	david	April 22, 2014, 12:58 a.m.
dict.get() defaults to None if the key doesn't exist, so you don't need to specify this second parameter.	david	April 22, 2014, 12:58 a.m.
dict.get() defaults to None if the key doesn't exist, so you don't need to specify this second parameter.	david	April 22, 2014, 12:58 a.m.
Two blank lines between top-level things.	david	April 22, 2014, 12:58 a.m.
Can you try to shorten and/or re-wrap this to keep it under 80 columns?	david	April 22, 2014, 12:58 a.m.
dict.get() defaults to None if the key doesn't exist, so you don't need to specify this second parameter.	david	April 22, 2014, 12:58 a.m.

Description:

~		This is a GitHub post-receive hook that will automatically close review requests as "submitted" after a push. To determine which review requests should be closed, it scans through each commit's commit message for the following strings (case-insensitive): "Reviewed at <reviewboard_url>/r/<id>" or "Review request #<id>".
	~	This is a Beanstalk post-receive hook that will automatically close review requests as "submitted" after a push. To determine which review requests should be closed, it scans through each commit's commit message for the following strings (case-insensitive): "Reviewed at <reviewboard_url>/r/<id>" or "Review request #<id>".

		Things left to do:
		1) Add support for SVN
		2) Add more tests for both repositories.

Description:

		This is a Beanstalk post-receive hook that will automatically close review requests as "submitted" after a push. To determine which review requests should be closed, it scans through each commit's commit message for the following strings (case-insensitive): "Reviewed at <reviewboard_url>/r/<id>" or "Review request #<id>".

~		Things left to do:
~		1) Add support for SVN
	~	This is what the JSON payload looks like:
	~	http://support.beanstalkapp.com/customer/portal/articles/75753-trigger-a-url-on-commit-with-web-hooks
-		2) Add more tests for both repositories.

Testing Done:

~		Performed basic test on a Git repository. It works. More tests need to be performed.
	~	Test carried out on git repo.
	+
	+	1) Push with the review request id in the commit message. Review request closed. [PASSED]
	+	2) Push without a review request id in the commit message. (Review request closed based on the commit_id) [PASSED].
	+	3) Push with non existent review request id. (Error: Review request does not exist) [PASSED]
	+	4) Push with review id in the message that is already submitted. (logged a warning: request id already submitted.) [PASSED]
	+	5) Push with review id in the message that has been marked as discarded. (review request marked as submitted.) [PASSED]

Commit:

-	7dd4cae02699b44f0f0ee88b06673d0e6f7c8899
+	826c48f40cd6548ff37728661f9d451a4b950855

Diff:

Revision 2 (+82)

Show changes

reviewboard/hostingsvcs/beanstalk.py

reviewboard/hostingsvcs/beanstalk.py (Diff revision 2)
Show all issues
```
Remove this line.
```
reviewboard/hostingsvcs/beanstalk.py (Diff revision 2)
Show all issues
```
Remove this line.
```

reviewboard/hostingsvcs/beanstalk.py (Diff revision 2)

Show all issues

We've switched over to using the new exception syntax:

try:
    ...
except KeyError as e:
    ...

reviewboard/hostingsvcs/beanstalk.py (Diff revision 2)

Show all issues

We've switched over to using the new exception syntax:

try:
    ...
except KeyError as e:
    ...

reviewboard/hostingsvcs/beanstalk.py (Diff revision 2)

Show all issues

How would you feel about introducing another method that could do this check and fan out to the individual implementations?

reviewboard/hostingsvcs/beanstalk.py (Diff revision 2)

Show all issues

dict.get() defaults to None if the key doesn't exist, so you don't need to specify this second parameter.

reviewboard/hostingsvcs/beanstalk.py (Diff revision 2)
Show all issues
```
Two blank lines between top-level things.
```

reviewboard/hostingsvcs/beanstalk.py (Diff revision 2)

Show all issues

Can you try to shorten and/or re-wrap this to keep it under 80 columns?

reviewboard/hostingsvcs/beanstalk.py (Diff revision 2)

Show all issues

dict.get() defaults to None if the key doesn't exist, so you don't need to specify this second parameter.

reviewboard/hostingsvcs/beanstalk.py (Diff revision 2)

Show all issues

dict.get() defaults to None if the key doesn't exist, so you don't need to specify this second parameter.

reviewboard/hostingsvcs/beanstalk.py (Diff revision 2)
Show all issues
```
Two blank lines between top-level things.
```

reviewboard/hostingsvcs/beanstalk.py (Diff revision 2)

Show all issues

Can you try to shorten and/or re-wrap this to keep it under 80 columns?

reviewboard/hostingsvcs/beanstalk.py (Diff revision 2)

Show all issues

dict.get() defaults to None if the key doesn't exist, so you don't need to specify this second parameter.

reviewboard/hostingsvcs/beanstalk.py (Diff revision 2)

Show all issues

So the individual implementations close the review requests or they just return the review_id_to_commits map as they do now ?

Change Summary:

Added support for SVN and tested for the same.

Testing Done:

~		Test carried out on git repo.
	~	Test carried out on git and svn repo.

		1) Push with the review request id in the commit message. Review request closed. [PASSED]
~		2) Push without a review request id in the commit message. (Review request closed based on the commit_id) [PASSED].
	~	2) Push without a review request id in the commit message. (Review request closed based on the commit_id for git and error looged for svn) [PASSED].
		3) Push with non existent review request id. (Error: Review request does not exist) [PASSED]
		4) Push with review id in the message that is already submitted. (logged a warning: request id already submitted.) [PASSED]
		5) Push with review id in the message that has been marked as discarded. (review request marked as submitted.) [PASSED]

Commit:

-	826c48f40cd6548ff37728661f9d451a4b950855
+	b77457d0f977e3b4249f282d70de797f040acd01

Diff:

Revision 3 (+83)

Show changes

reviewboard/hostingsvcs/beanstalk.py

Testing Done:

~		Test carried out on git and svn repo.
	~	Test carried out on git and svn repos.

		1) Push with the review request id in the commit message. Review request closed. [PASSED]
		2) Push without a review request id in the commit message. (Review request closed based on the commit_id for git and error looged for svn) [PASSED].
		3) Push with non existent review request id. (Error: Review request does not exist) [PASSED]
		4) Push with review id in the message that is already submitted. (logged a warning: request id already submitted.) [PASSED]
		5) Push with review id in the message that has been marked as discarded. (review request marked as submitted.) [PASSED]

Summary:

-	[WIP] Beanstalk post-receive web hook
+	Beanstalk post-receive web hook

Status: Closed (submitted)

Change Summary:

Pushed to master (4bd49ff)

Ship it!

```
Ship It!
```