Move some more API access methods into GitHubClient.

Review Request #5697 — Created April 10, 2014 and submitted

Information

Review Board
master
cccb558...

Reviewers

This change moves some higher-level API access code out of the GitHub hosting
service and into GitHubClient. As a side-effect of this change, errors when
trying to fetch branches or commits are bubbled up correctly.

  • Ran unit tests.
  • Tested post-commit review request creation.
Description From Last Updated

We've removed/hidden usage of _build_api_url elsewhere. Can we do that here?

chipx86chipx86
david
chipx86
  1. 
      
  2. reviewboard/hostingsvcs/github.py (Diff revision 2)
     
     
     
     
     
     
    Show all issues

    We've removed/hidden usage of _build_api_url elsewhere. Can we do that here?

    1. There's more that can be moved into the client, but the ones that this change doesn't address were annoying. We can address more of that later.

  3. 
      
chipx86
  1. Ship It!

  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to master (ed6bef9)