Summary

Move some more API access methods into GitHubClient.

Review Request #5697 — Created April 10, 2014 and submitted April 17, 2014, 5:31 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Commit

cccb558...

Reviewers

Groups

reviewboard

People

Description

This change moves some higher-level API access code out of the GitHub hosting
service and into GitHubClient. As a side-effect of this change, errors when
trying to fetch branches or commits are bubbled up correctly.

Testing Done


Ran unit tests.
Tested post-commit review request creation.

Issues

Description	From	Last Updated
We've removed/hidden usage of _build_api_url elsewhere. Can we do that here?	chipx86	April 11, 2014, 11:07 p.m.

Change Summary:

Move the RAW_MIMETYPE definition, too.

Testing Done:

~		Ran unit tests.
	~	Ran unit tests.
	+	Tested post-commit review request creation.

Commit:

683af25747c386c7ca8e98db9b128bd725341f0e

cccb558a68dbde4553af10ed955ed40554a9bb90

Diff:

Revision 2 (+107 -91)

Show changes

reviewboard/hostingsvcs/github.py

reviewboard/hostingsvcs/github.py (Diff revision 2)

The issue has been dropped. Show all issues

We've removed/hidden usage of _build_api_url elsewhere. Can we do that here?

david

April 11, 2014, 11:07 p.m.

There's more that can be moved into the client, but the ones that this change doesn't address were annoying. We can address more of that later.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (ed6bef9)