Support building media with parallel-installed Django

Review Request #5690 — Created April 9, 2014 and submitted

Information

Review Board
release-1.7.x
0d810c9...

Reviewers

On systems such as Fedora where older versions of Django are
installed as alternative versions (and not directly importable),
we need to ensure that we are importing exactly the right version
of the Django modules.

This patch adds a new variable in the reviewboard __init__.py that is
imported by both setup.py and build-media.py to ensure that they
are both relying on the same version of Django.

Built successfully on Fedora.

Description From Last Updated

Can you put the dependency info in some central place (such as reviewboard/__init__.py) and import it from both here and …

daviddavid

Instead of adding a new top-level file just for this, I think I'd rather it be another entry in reviewboard/__init__.py

daviddavid
david
  1. 
      
  2. contrib/internal/build-media.py (Diff revision 1)
     
     
    Show all issues

    Can you put the dependency info in some central place (such as reviewboard/__init__.py) and import it from both here and setup.py? I really don't want to introduce multiple places that we have to remember to change when we bump versions.

  3. 
      
sgallagh
david
  1. 
      
  2. dependencies.py (Diff revision 2)
     
     
    Show all issues

    Instead of adding a new top-level file just for this, I think I'd rather it be another entry in reviewboard/__init__.py

  3. 
      
sgallagh
david
  1. Ship It!

  2. 
      
sgallagh
Review request changed
Status:
Completed
Change Summary:
Pushed to release-1.7.x (27df042)