Support building media with parallel-installed Django

Review Request #5689 — Created April 9, 2014 and submitted

sgallagh
Djblets
release-0.7.x
5690
5c98059...
djblets

On systems such as Fedora where older versions of Django are
installed as alternative versions (and not directly importable),
we need to ensure that we are importing exactly the right version
of the Django modules.

This patch adds a new variable in the djblets __init__.py that is
imported by both setup.py and build-media.py to ensure that they
are both relying on the same version of Django.

This doesn't get handled automatically by setuptools because this
script is invoked directly via sys.executable() in BuildMedia().

Successfully built Djblets for Fedora

Description From Last Updated

Same comment as on the reviewboard change, I'd rather see this in djblets/__init__.py

daviddavid

Once the django version is in __init__.py (and you're adding to this line), could you move this import back up …

daviddavid
david
  1. Can you put the dependency info in some central place (such as djblets/__init__.py) and import it from both here and setup.py? I really don't want to introduce multiple places that we have to remember to change when we bump versions.

  2. 
      
sgallagh
david
  1. 
      
  2. dependencies.py (Diff revision 2)
     
     

    Same comment as on the reviewboard change, I'd rather see this in djblets/__init__.py

  3. setup.py (Diff revision 2)
     
     

    Once the django version is in __init__.py (and you're adding to this line), could you move this import back up to be next to the other imports?

  4. 
      
sgallagh
david
  1. Ship It!

  2. 
      
sgallagh
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-0.7.x (8508d95)
Loading...