Return an error if trying to set a summary with newlines.

Review Request #569 — Created Sept. 29, 2008 and submitted

Information

Review Board SVN (deprecated)
trunk
548

Reviewers

Return an error if trying to set a summary with newlines.
    
At the moment, it's possible to create a review request that has a summary with
a newline in it. This works okay until RB tries to send email with that summary
as a subject, at which point it will blow up with an ugly backtrace.
    
I considered normalizing, but that's uglier. Since this is something that can
only be done via the JSON API, we might as well have the API return an error
instead.

 
chipx86
  1. Looks good, just one comment..
  2. /trunk/reviewboard/webapi/json.py (Diff revision 1)
     
     
    Should this be localized?
    1. We don't localize anything else in our API errors.
    2. Fair point. Ship it!
  3. 
      
Loading...