Support building media with parallel-installed Django
Review Request #5689 — Created April 9, 2014 and submitted
On systems such as Fedora where older versions of Django are
installed as alternative versions (and not directly importable),
we need to ensure that we are importing exactly the right version
of the Django modules.This patch adds a new variable in the djblets __init__.py that is
imported by both setup.py and build-media.py to ensure that they
are both relying on the same version of Django.This doesn't get handled automatically by setuptools because this
script is invoked directly via sys.executable() in BuildMedia().
Successfully built Djblets for Fedora
- Change Summary:
-
Addresses the earlier review comment and stores the version in a single place
- Summary:
-
Support building with parallel-installed DjangoSupport building media with parallel-installed Django
- Description:
-
On systems such as Fedora where older versions of Django are
installed as alternative versions (and not directly importable), we need to ensure that we are importing exactly the right version of the Django modules. ~ This doesn't get handled automatically by setuptools because this script is invoked directly via sys.executable() in BuildMedia().
~ This patch adds a new shared dependencies.py file in the root path
+ that is imported by both setup.py and build-media.py to ensure that + they are both relying on the same version of Django. ~ Note: it's safe to use the generic >1.4,<1.5 approach here because setuptools for the rest of the build has already guaranteed the minor 1.4 version.
~ This doesn't get handled automatically by setuptools because this
+ script is invoked directly via sys.executable() in BuildMedia(). - Commit:
-
8596f893d379c2c9819e37d9f67a478681219671cc6290e47af5a69ed55eff0bcf459381e36d728a
- Change Summary:
-
Moved the version to init.py and dropped the dependencies.py file.
- Description:
-
On systems such as Fedora where older versions of Django are
installed as alternative versions (and not directly importable), we need to ensure that we are importing exactly the right version of the Django modules. ~ This patch adds a new shared dependencies.py file in the root path
~ that is imported by both setup.py and build-media.py to ensure that ~ they are both relying on the same version of Django. ~ This patch adds a new variable in the djblets __init__.py that is
~ imported by both setup.py and build-media.py to ensure that they ~ are both relying on the same version of Django. This doesn't get handled automatically by setuptools because this
script is invoked directly via sys.executable() in BuildMedia(). - Commit:
-
cc6290e47af5a69ed55eff0bcf459381e36d728a5c98059dd5111fa6bab3e03fc55b265c36dea7ba