- Download Diff

Summary:

[WIP] Adding and removing widgets

Review Request #5676 — Created April 4, 2014 and discarded May 13, 2014, 2:44 p.m.

Information
Owner:	hellosjsu
Repository:	Review Board
Branch:	master
Bugs:
Depends On:
Reviewers
Groups:	reviewboard, students
People:

Description

Users can add widgets to their admin dashboard by clicking on "Add Widgets," which will open a modal displaying a list of widgets that they can choose from.

Users can remove widgets by clicking the X in the upper right hand corner. A confirmation dialogue will appear to ask the user if they are sure.

Testing Done

Files

Issues

Description	From	Last Updated
the default parameter for dict.get defaults to None, so you don't need to include the second argument.	david	April 25, 2014, 7:53 p.m.
the default parameter for dict.get defaults to None, so you don't need to include the second argument.	david	April 25, 2014, 7:53 p.m.
This should probably check if widget is not None before assigning to positions.	david	April 25, 2014, 7:53 p.m.
Two blank lines between top-level items in the file.	david	April 25, 2014, 7:53 p.m.
Same comment re: get.	david	April 25, 2014, 7:53 p.m.
Same comment re: get.	david	April 25, 2014, 7:53 p.m.
Should test that widget_position isn't None.	david	April 25, 2014, 7:53 p.m.
Two blank lines.	david	April 25, 2014, 7:53 p.m.
Old code, but this should be two blank lines.	david	April 25, 2014, 7:53 p.m.
The parens don't really add anything here.	david	April 25, 2014, 7:53 p.m.
Remove the spaces inside of the parens.	david	April 25, 2014, 7:53 p.m.
This line should be 4-space indented.	david	April 25, 2014, 7:54 p.m.
Leftover debug code?	david	April 25, 2014, 7:54 p.m.
Remove the spaces inside the parens.	david	April 25, 2014, 7:54 p.m.
Remove the spaces inside the parens.	david	April 25, 2014, 7:54 p.m.
This line should be 4-space indented.	david	April 25, 2014, 7:54 p.m.
Remove the spaces inside the parens.	david	April 25, 2014, 7:54 p.m.
Remove the spaces inside the parens.	david	April 25, 2014, 7:54 p.m.
Alignment in HTML should use single spaces instead of tabs. Please check this for all your newly-added code here.	david	April 25, 2014, 7:54 p.m.
This should use {% trans "Manage Large Widgets" %} so that translators can localize it to other languages.	david	April 25, 2014, 7:54 p.m.
This should use {% trans "Manage Small Widgets" %} so that translators can localize it to other languages.	david	April 25, 2014, 7:54 p.m.
{% trans %}	david	April 25, 2014, 7:54 p.m.
This should use {% trans "Save Widgets" %} so that translators can localize it to other languages.	david	April 25, 2014, 7:54 p.m.
{% trans %}	david	April 25, 2014, 7:54 p.m.
{% trans %}	david	April 25, 2014, 7:54 p.m.

Description:

		Users can add or remove widgets to their admin dashboard by clicking on "Manage Widgets," which will open a modal displaying a list of widgets that they can choose from.
	+
	+	Note 4/5/13: Ignore the changes on views.py for now (They're from the drag & drop feature that's already been shipped; I'm not sure why they show up as new changes here.)

Added Files:

Groups:

+	students

Description:

		Users can add or remove widgets to their admin dashboard by clicking on "Manage Widgets," which will open a modal displaying a list of widgets that they can choose from.

~		Note 4/5/13: Ignore the changes on views.py for now (They're from the drag & drop feature that's already been shipped; I'm not sure why they show up as new changes here.)
	~	Note 4/5/13: Ignore the changes on views.py for now (They're from the drag & drop feature that's already been shipped; I messed up when rebasing on top of master.)

reviewboard/admin/views.py (Diff revision 1)

Show all issues

the default parameter for dict.get defaults to None, so you don't need to include the second argument.

reviewboard/admin/views.py (Diff revision 1)

Show all issues

the default parameter for dict.get defaults to None, so you don't need to include the second argument.

reviewboard/admin/views.py (Diff revision 1)

Show all issues

This should probably check if widget is not None before assigning to positions.

reviewboard/admin/views.py (Diff revision 1)

Show all issues

Two blank lines between top-level items in the file.

reviewboard/admin/views.py (Diff revision 1)
Show all issues
```
Same comment re: get.
```
reviewboard/admin/views.py (Diff revision 1)
Show all issues
```
Same comment re: get.
```
reviewboard/admin/views.py (Diff revision 1)
Show all issues
```
Should test that widget_position isn't None.
```
reviewboard/admin/views.py (Diff revision 1)
Show all issues
```
Two blank lines.
```

reviewboard/admin/views.py (Diff revision 1)

Show all issues

Old code, but this should be two blank lines.

reviewboard/static/rb/css/admin-dashboard.less (Diff revision 1)
Show all issues
```
The parens don't really add anything here.
```
reviewboard/static/rb/js/admin.js (Diff revision 1)
Show all issues
```
Remove the spaces inside of the parens.
```
reviewboard/static/rb/js/admin.js (Diff revision 1)
Show all issues
```
This line should be 4-space indented.
```
reviewboard/static/rb/js/admin.js (Diff revision 1)
Show all issues
```
Leftover debug code?
```
reviewboard/static/rb/js/admin.js (Diff revision 1)
Show all issues
```
Remove the spaces inside the parens.
```
reviewboard/static/rb/js/admin.js (Diff revision 1)
Show all issues
```
Remove the spaces inside the parens.
```
reviewboard/static/rb/js/admin.js (Diff revision 1)
Show all issues
```
This line should be 4-space indented.
```
reviewboard/static/rb/js/admin.js (Diff revision 1)
Show all issues
```
Remove the spaces inside the parens.
```
reviewboard/static/rb/js/admin.js (Diff revision 1)
Show all issues
```
Remove the spaces inside the parens.
```

reviewboard/templates/admin/dashboard.html (Diff revision 1)

Show all issues

Alignment in HTML should use single spaces instead of tabs. Please check this for all your newly-added code here.

reviewboard/templates/admin/dashboard.html (Diff revision 1)

Show all issues

This should use {% trans "Manage Large Widgets" %} so that translators can localize it to other languages.

reviewboard/templates/admin/dashboard.html (Diff revision 1)

Show all issues

This should use {% trans "Manage Small Widgets" %} so that translators can localize it to other languages.

reviewboard/templates/admin/dashboard.html (Diff revision 1)
Show all issues
```
{% trans %}
```

reviewboard/templates/admin/dashboard.html (Diff revision 1)

Show all issues

This should use {% trans "Save Widgets" %} so that translators can localize it to other languages.

reviewboard/templates/admin/dashboard.html (Diff revision 1)
Show all issues
```
{% trans %}
```
reviewboard/templates/admin/dashboard.html (Diff revision 1)
Show all issues
```
{% trans %}
```

Diff:

Revision 2 (+251 -5)

Show changes

	reviewboard/admin/urls.py
	reviewboard/admin/views.py
	reviewboard/static/rb/css/admin-dashboard.less
	reviewboard/static/rb/css/icons.less
	reviewboard/static/rb/images/activity-graph-widget.png
	reviewboard/static/rb/images/database-stats-widget.png
	reviewboard/static/rb/images/news-widget.png
	reviewboard/static/rb/images/recent-actions-widget.png
	9 more

Summary:

-	Front end for adding/removing widgets
+	[WIP] Adding and removing widgets

Description:

~		Users can add or remove widgets to their admin dashboard by clicking on "Manage Widgets," which will open a modal displaying a list of widgets that they can choose from.
	~	Users can add widgets to their admin dashboard by clicking on "Add Widgets," which will open a modal displaying a list of widgets that they can choose from.

~		Note 4/5/13: Ignore the changes on views.py for now (They're from the drag & drop feature that's already been shipped; I messed up when rebasing on top of master.)
	~	Users can remove widgets by clicking the X in the upper right hand corner. A confirmation dialogue will appear to ask the user if they are sure.

Added Files:

It looks like this change is subsumed by /r/5622? If not, can you clarify the difference, and if so, discard this one?

Status: Discarded

Change Summary:

Old change.

You have a pending review.

Review Board 5.0.2 alpha 0 (dev)

[WIP] Adding and removing widgets

Description:

Added Files:

Groups:

Description:

Diff:

Summary:

Description:

Added Files:

Status: Discarded

Change Summary: