Description: |
|
---|
[WIP] Adding and removing widgets
Review Request #5676 — Created April 4, 2014 and discarded
Information | |
---|---|
hellosjsu | |
Review Board | |
master | |
Reviewers | |
reviewboard, students | |
Users can add widgets to their admin dashboard by clicking on "Add Widgets," which will open a modal displaying a list of widgets that they can choose from.
Users can remove widgets by clicking the X in the upper right hand corner. A confirmation dialogue will appear to ask the user if they are sure.
Description | From | Last Updated |
---|---|---|
the default parameter for dict.get defaults to None, so you don't need to include the second argument. |
|
|
the default parameter for dict.get defaults to None, so you don't need to include the second argument. |
|
|
This should probably check if widget is not None before assigning to positions. |
|
|
Two blank lines between top-level items in the file. |
|
|
Same comment re: get. |
|
|
Same comment re: get. |
|
|
Should test that widget_position isn't None. |
|
|
Two blank lines. |
|
|
Old code, but this should be two blank lines. |
|
|
The parens don't really add anything here. |
|
|
Remove the spaces inside of the parens. |
|
|
This line should be 4-space indented. |
|
|
Leftover debug code? |
|
|
Remove the spaces inside the parens. |
|
|
Remove the spaces inside the parens. |
|
|
This line should be 4-space indented. |
|
|
Remove the spaces inside the parens. |
|
|
Remove the spaces inside the parens. |
|
|
Alignment in HTML should use single spaces instead of tabs. Please check this for all your newly-added code here. |
|
|
This should use {% trans "Manage Large Widgets" %} so that translators can localize it to other languages. |
|
|
This should use {% trans "Manage Small Widgets" %} so that translators can localize it to other languages. |
|
|
{% trans %} |
|
|
This should use {% trans "Save Widgets" %} so that translators can localize it to other languages. |
|
|
{% trans %} |
|
|
{% trans %} |
|
Description: |
|
---|
-
-
reviewboard/admin/views.py (Diff revision 1) the
default
parameter fordict.get
defaults toNone
, so you don't need to include the second argument. -
reviewboard/admin/views.py (Diff revision 1) the
default
parameter fordict.get
defaults toNone
, so you don't need to include the second argument. -
reviewboard/admin/views.py (Diff revision 1) This should probably check
if widget is not None
before assigning topositions
. -
-
-
-
-
-
-
reviewboard/static/rb/css/admin-dashboard.less (Diff revision 1) The parens don't really add anything here.
-
-
-
-
-
-
-
-
-
reviewboard/templates/admin/dashboard.html (Diff revision 1) Alignment in HTML should use single spaces instead of tabs. Please check this for all your newly-added code here.
-
reviewboard/templates/admin/dashboard.html (Diff revision 1) This should use
{% trans "Manage Large Widgets" %}
so that translators can localize it to other languages. -
reviewboard/templates/admin/dashboard.html (Diff revision 1) This should use
{% trans "Manage Small Widgets" %}
so that translators can localize it to other languages. -
-
reviewboard/templates/admin/dashboard.html (Diff revision 1) This should use
{% trans "Save Widgets" %}
so that translators can localize it to other languages. -
-
Description: |
|
---|