Review Request #5676 — Created April 5, 2014 and discarded
Users can add widgets to their admin dashboard by clicking on "Add Widgets," which will open a modal displaying a list of widgets that they can choose from.
Users can remove widgets by clicking the X in the upper right hand corner. A confirmation dialogue will appear to ask the user if they are sure.
| Description | From | Last Updated |
|---|---|---|
|
the default parameter for dict.get defaults to None, so you don't need to include the second argument. |
david
|
|
|
the default parameter for dict.get defaults to None, so you don't need to include the second argument. |
david
|
|
|
This should probably check if widget is not None before assigning to positions. |
david
|
|
|
Two blank lines between top-level items in the file. |
david
|
|
|
Same comment re: get. |
david
|
|
|
Same comment re: get. |
david
|
|
|
Should test that widget_position isn't None. |
david
|
|
|
Two blank lines. |
david
|
|
|
Old code, but this should be two blank lines. |
david
|
|
|
The parens don't really add anything here. |
david
|
|
|
Remove the spaces inside of the parens. |
david
|
|
|
This line should be 4-space indented. |
david
|
|
|
Leftover debug code? |
david
|
|
|
Remove the spaces inside the parens. |
david
|
|
|
Remove the spaces inside the parens. |
david
|
|
|
This line should be 4-space indented. |
david
|
|
|
Remove the spaces inside the parens. |
david
|
|
|
Remove the spaces inside the parens. |
david
|
|
|
Alignment in HTML should use single spaces instead of tabs. Please check this for all your newly-added code here. |
david
|
|
|
This should use {% trans "Manage Large Widgets" %} so that translators can localize it to other languages. |
david
|
|
|
This should use {% trans "Manage Small Widgets" %} so that translators can localize it to other languages. |
david
|
|
|
{% trans %} |
david
|
|
|
This should use {% trans "Save Widgets" %} so that translators can localize it to other languages. |
david
|
|
|
{% trans %} |
david
|
|
|
{% trans %} |
david
|
Users can add or remove widgets to their admin dashboard by clicking on "Manage Widgets," which will open a modal displaying a list of widgets that they can choose from. | ||
| + | ||
| + | Note 4/5/13: Ignore the changes on views.py for now (They're from the drag & drop feature that's already been shipped; I'm not sure why they show up as new changes here.) |
Users can add or remove widgets to their admin dashboard by clicking on "Manage Widgets," which will open a modal displaying a list of widgets that they can choose from. | ||
| ~ | Note 4/5/13: Ignore the changes on views.py for now (They're from the drag & drop feature that's already been shipped; I'm not sure why they show up as new changes here.) | |
| ~ | Note 4/5/13: Ignore the changes on views.py for now (They're from the drag & drop feature that's already been shipped; I messed up when rebasing on top of master.) |
the
defaultparameter fordict.getdefaults toNone, so you don't need to include the second argument.
the
defaultparameter fordict.getdefaults toNone, so you don't need to include the second argument.
Alignment in HTML should use single spaces instead of tabs. Please check this for all your newly-added code here.
This should use
{% trans "Manage Large Widgets" %}so that translators can localize it to other languages.
This should use
{% trans "Manage Small Widgets" %}so that translators can localize it to other languages.
Revision 2 (+251 -5)
| ~ | Users can add or remove widgets to their admin dashboard by clicking on "Manage Widgets," which will open a modal displaying a list of widgets that they can choose from. | |
| ~ | Users can add widgets to their admin dashboard by clicking on "Add Widgets," which will open a modal displaying a list of widgets that they can choose from. | |
| ~ | Note 4/5/13: Ignore the changes on views.py for now (They're from the drag & drop feature that's already been shipped; I messed up when rebasing on top of master.) | |
| ~ | Users can remove widgets by clicking the X in the upper right hand corner. A confirmation dialogue will appear to ask the user if they are sure. |
