[WIP] Adding and removing widgets

Review Request #5676 — Created April 4, 2014 and discarded

Information

Review Board
master

Reviewers

Users can add widgets to their admin dashboard by clicking on "Add Widgets," which will open a modal displaying a list of widgets that they can choose from.

Users can remove widgets by clicking the X in the upper right hand corner. A confirmation dialogue will appear to ask the user if they are sure.


 

Description From Last Updated

the default parameter for dict.get defaults to None, so you don't need to include the second argument.

daviddavid

the default parameter for dict.get defaults to None, so you don't need to include the second argument.

daviddavid

This should probably check if widget is not None before assigning to positions.

daviddavid

Two blank lines between top-level items in the file.

daviddavid

Same comment re: get.

daviddavid

Same comment re: get.

daviddavid

Should test that widget_position isn't None.

daviddavid

Two blank lines.

daviddavid

Old code, but this should be two blank lines.

daviddavid

The parens don't really add anything here.

daviddavid

Remove the spaces inside of the parens.

daviddavid

This line should be 4-space indented.

daviddavid

Leftover debug code?

daviddavid

Remove the spaces inside the parens.

daviddavid

Remove the spaces inside the parens.

daviddavid

This line should be 4-space indented.

daviddavid

Remove the spaces inside the parens.

daviddavid

Remove the spaces inside the parens.

daviddavid

Alignment in HTML should use single spaces instead of tabs. Please check this for all your newly-added code here.

daviddavid

This should use {% trans "Manage Large Widgets" %} so that translators can localize it to other languages.

daviddavid

This should use {% trans "Manage Small Widgets" %} so that translators can localize it to other languages.

daviddavid

{% trans %}

daviddavid

This should use {% trans "Save Widgets" %} so that translators can localize it to other languages.

daviddavid

{% trans %}

daviddavid

{% trans %}

daviddavid
HE
HE
HE
HE
HE
HE
david
  1. 
      
  2. reviewboard/admin/views.py (Diff revision 1)
     
     
    Show all issues

    the default parameter for dict.get defaults to None, so you don't need to include the second argument.

  3. reviewboard/admin/views.py (Diff revision 1)
     
     
    Show all issues

    the default parameter for dict.get defaults to None, so you don't need to include the second argument.

  4. reviewboard/admin/views.py (Diff revision 1)
     
     
    Show all issues

    This should probably check if widget is not None before assigning to positions.

  5. reviewboard/admin/views.py (Diff revision 1)
     
     
     
     
    Show all issues

    Two blank lines between top-level items in the file.

  6. reviewboard/admin/views.py (Diff revision 1)
     
     
    Show all issues

    Same comment re: get.

  7. reviewboard/admin/views.py (Diff revision 1)
     
     
    Show all issues

    Same comment re: get.

  8. reviewboard/admin/views.py (Diff revision 1)
     
     
    Show all issues

    Should test that widget_position isn't None.

  9. reviewboard/admin/views.py (Diff revision 1)
     
     
     
     
    Show all issues

    Two blank lines.

  10. reviewboard/admin/views.py (Diff revision 1)
     
     
     
     
    Show all issues

    Old code, but this should be two blank lines.

  11. Show all issues

    The parens don't really add anything here.

  12. reviewboard/static/rb/js/admin.js (Diff revision 1)
     
     
    Show all issues

    Remove the spaces inside of the parens.

  13. reviewboard/static/rb/js/admin.js (Diff revision 1)
     
     
    Show all issues

    This line should be 4-space indented.

  14. reviewboard/static/rb/js/admin.js (Diff revision 1)
     
     
    Show all issues

    Leftover debug code?

  15. reviewboard/static/rb/js/admin.js (Diff revision 1)
     
     
    Show all issues

    Remove the spaces inside the parens.

  16. reviewboard/static/rb/js/admin.js (Diff revision 1)
     
     
    Show all issues

    Remove the spaces inside the parens.

  17. reviewboard/static/rb/js/admin.js (Diff revision 1)
     
     
    Show all issues

    This line should be 4-space indented.

  18. reviewboard/static/rb/js/admin.js (Diff revision 1)
     
     
    Show all issues

    Remove the spaces inside the parens.

  19. reviewboard/static/rb/js/admin.js (Diff revision 1)
     
     
    Show all issues

    Remove the spaces inside the parens.

  20. reviewboard/templates/admin/dashboard.html (Diff revision 1)
     
     
     
     
    Show all issues

    Alignment in HTML should use single spaces instead of tabs. Please check this for all your newly-added code here.

  21. Show all issues

    This should use {% trans "Manage Large Widgets" %} so that translators can localize it to other languages.

  22. Show all issues

    This should use {% trans "Manage Small Widgets" %} so that translators can localize it to other languages.

  23. Show all issues

    {% trans %}

  24. Show all issues

    This should use {% trans "Save Widgets" %} so that translators can localize it to other languages.

  25. Show all issues

    {% trans %}

  26. Show all issues

    {% trans %}

  27. 
      
HE
HE
HE
HE
david
  1. It looks like this change is subsumed by /r/5622? If not, can you clarify the difference, and if so, discard this one?

  2. 
      
HE
Review request changed

Status: Discarded

Change Summary:

Old change.
Loading...