Fish Trophy

chipx86 got a fish trophy!

Switch to the HTML5 DTD.

Review Request #5665 — Created April 1, 2014 and submitted

Information

Review Board
master
3d6772d...

Reviewers

We were using the XHTML 1 Transitional DTD for the longest time for
Review Board. This ends up putting the browsers into a mode where
some of the more recent rules won't apply. For the most part, we're
unaffected by any of these quirks, but I ran into something I was
working on where this did matter. It's also more likely to impact us in
the future.

Tested all Dashboard functionality.

Tested editing fields on a review request and interacting with dialogs.

Tested opening/closing reviews and replying to reviews.

Tested commenting on diffs.

Tested the admin UI.

Tested the My Account page.

Went through various other pages, looking for visual issues, and didn't
see any.

david
  1. We also use the XHTML doctype in reviewboard/htdocs/errordocs/500.html and reviewboard/templates/500.html

  2. 
      
chipx86
david
  1. Ship It!

  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Loading...