Summary

Bitbucket post-receive hook

Review Request #5653 — Created March 22, 2014 and submitted April 14, 2014, 1:14 p.m.

Information

Owner

b.ramnani

Repository

Review Board

Branch

master

Bugs

Depends On

~~5596~~

Commit

891b835...

Reviewers

Groups

reviewboard

People

anselina, chipx86, david, mike_conley, smacleod

Description

This is a Bitbucket post-receive hook that will automatically close review requests as "submitted" after a push. To determine which review requests should be closed, it scans through each commit's commit message for the following strings (case-insensitive): "Reviewed at <reviewboard_url>/r/<id>" or "Review request #<id>". The regex used for this can be overriden in settings_local.py.

Testing Done

Basic testing on a git repo performed. Test passed successfully (see screenshot).
All tests carried out on both mercurial and git repos.
Tests:

1) Close an open review request. [PASSED]

2) Try to close a review request that already has been closed as submitted. (Logged a warning saying that the review request has already been submitted). [PASSED]

3) Try to close a discarded review request. (Marked the review request as submitted) [PASSED]

4) Push without a review request id in commit message. (Error logged that the request id does not exist). [PASSED]

5) Push with a non existent request id in the commit message. (Error logged as Review request id does not exist.) [PASSED]

Files

Issues

Description	From	Last Updated
This can be combined to a single import (http://docs.python.org/2/reference/simple_stmts.html#the-import-statement)	TO tomiaijo	March 29, 2014, 1:37 a.m.
Change this to: repository_url_patterns = patterns( '', url(r'^hooks/post-receive/$', 'reviewboard.hostingsvcs.tests.hosting_service_url_test_view') )	anselina	March 29, 2014, 1:37 a.m.
Trailing whitespace	TO tomiaijo	March 29, 2014, 1:37 a.m.
You should delete these lines because the URLs are already dynamically generated.	anselina	March 29, 2014, 1:37 a.m.
Mixed tabs and whitespaces	TO tomiaijo	March 29, 2014, 1:37 a.m.
Only for temporary testing	B. b.ramnani	March 29, 2014, 1:37 a.m.
You didn't add any logging, so this import can go away.	david	April 9, 2014, 9:19 p.m.
This isn't used.	david	April 9, 2014, 9:53 p.m.
This line isn't necessary.	david	April 9, 2014, 9:23 p.m.
If review_id_to_commits is an empty map, close_all_review_requests will be a no-op. Therefore I think you can remove the test and …	david	April 9, 2014, 9:23 p.m.

reviewboard/hostingsvcs/bitbucket.py (Diff revision 1)

The issue has been resolved. Show all issues

This can be combined to a single import  (http://docs.python.org/2/reference/simple_stmts.html#the-import-statement)

reviewboard/hostingsvcs/urls.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Trailing whitespace
```
reviewboard/hostingsvcs/urls.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Mixed tabs and whitespaces
```

reviewboard/hostingsvcs/urls.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Only for temporary testing
```

Making these changes should fix the problem you mentioned in your status report about the URLs not being added for Bitbucket! (Using your code in /r/5510, I've checked that the URLs are properly generated for GitHub, so everything's fine there.)

reviewboard/hostingsvcs/bitbucket.py (Diff revision 1)

The issue has been resolved. Show all issues

Change this to:
repository_url_patterns = patterns(
    '',
    url(r'^hooks/post-receive/$',
        'reviewboard.hostingsvcs.tests.hosting_service_url_test_view')
)

anselina March 23, 2014, 12:56 p.m.

Sorry, some style issues with what I said above - instead, change it to: 
repository_url_patterns = patterns(
    '',

    url(r'^hooks/post-receive/$',
        'reviewboard.hostingsvcs.tests.hosting_service_url_test_view'),
)


And also make sure you import patterns and url: from django.conf.urls import patterns, url

It should work after this!

reviewboard/hostingsvcs/urls.py (Diff revision 1)

The issue has been resolved. Show all issues

You should delete these lines because the URLs are already dynamically generated.

Change Summary:

Bitbucket post-receive hook: Draft 1

Testing Done:

	+	Basic testing on a git repo performed. Test passed successfully (see screenshot). Trying to test for mercurial repo but unable to do rbt post. see error below:
	+
	+	http://pastie.org/8977819
	+
	+	Would appreciate some help for above.
	+
	+
	+
	+	Further testing on both git and mercurial repos is pending.

People:

+	achia
+	mike_conley

Diff:

Revision 2 (+10 -12)

Show changes

reviewboard/hostingsvcs/bitbucket.py

Added Files:

Depends On:

+	~~5596 - Add GitHub post-receive hook to close review requests automatically.~~

Description:

~		Project to close review requests automatically when pushed to the bitbucket repository.
	~	This is a Bitbucket post-receive hook that will automatically close review requests as "submitted" after a push. To determine which review requests should be closed, it scans through each commit's commit message for the following strings (case-insensitive): "Reviewed at <reviewboard_url>/r/<id>" or "Review request #<id>". The regex used for this can be overriden in settings_local.py.
	+
	+
	+
	+	To Do:
	+	1) add check to see if the commit id in the review request matches the revision that got pushed (as suggested by David)
	+	2) Further testing on both git and mercurial repos is pending.

Testing Done:

		Basic testing on a git repo performed. Test passed successfully (see screenshot). Trying to test for mercurial repo but unable to do rbt post. see error below:

		http://pastie.org/8977819

		Would appreciate some help for above.
-
-
-
-		Further testing on both git and mercurial repos is pending.

Change Summary:

Added more tests

Description:

		This is a Bitbucket post-receive hook that will automatically close review requests as "submitted" after a push. To determine which review requests should be closed, it scans through each commit's commit message for the following strings (case-insensitive): "Reviewed at <reviewboard_url>/r/<id>" or "Review request #<id>". The regex used for this can be overriden in settings_local.py.
-
-
-
-		To Do:
-		1) add check to see if the commit id in the review request matches the revision that got pushed (as suggested by David)
-		2) Further testing on both git and mercurial repos is pending.

Testing Done:

~		Basic testing on a git repo performed. Test passed successfully (see screenshot). Trying to test for mercurial repo but unable to do rbt post. see error below:
	~	Basic testing on a git repo performed. Test passed successfully (see screenshot).

~		http://pastie.org/8977819
~
~		Would appreciate some help for above.
	~	Tests:
	~	1) Close an open review request. [PASSED]
	~	2) Try to close a review request that already has been closed as submitted. (Logged a warning saying that the review request has already been submitted). [PASSED]
	+	3) Try to close a discarded review request. (Marked the review request as submitted) [PASSED]
	+	4) Push without a review request id in commit message. (Error logged that the request id does not exist). [PASSED]
	+	5) Push with a non existent request id in the commit message. (Error logged as Review request id does not exist.) [PASSED]
	+	6) While trying to test feature implemented in rr #5666, I found that it wasn't working because the commit id for the review request was not updated on reviewboard backend. [FAILED]
	+	7) Push a change with someone else's review request id in the commit message. Was able to close someone else's review request. [FAILED]

Change Summary:

Added tests for mercurial repo.

Testing Done:

		Basic testing on a git repo performed. Test passed successfully (see screenshot).

	+	All tests carried out on both mercurial and git repos.
	+
		Tests:
		1) Close an open review request. [PASSED]
		2) Try to close a review request that already has been closed as submitted. (Logged a warning saying that the review request has already been submitted). [PASSED]
		3) Try to close a discarded review request. (Marked the review request as submitted) [PASSED]
		4) Push without a review request id in commit message. (Error logged that the request id does not exist). [PASSED]
		5) Push with a non existent request id in the commit message. (Error logged as Review request id does not exist.) [PASSED]
		6) While trying to test feature implemented in rr #5666, I found that it wasn't working because the commit id for the review request was not updated on reviewboard backend. [FAILED]
		7) Push a change with someone else's review request id in the commit message. Was able to close someone else's review request. [FAILED]

Diff:

Revision 3 (+3 -2)

Show changes

reviewboard/hostingsvcs/bitbucket.py

Summary:

-	[WIP] Bitbucket post-receive hook
+	Bitbucket post-receive hook

Testing Done:

		Basic testing on a git repo performed. Test passed successfully (see screenshot).

		All tests carried out on both mercurial and git repos.

		Tests:
		1) Close an open review request. [PASSED]
		2) Try to close a review request that already has been closed as submitted. (Logged a warning saying that the review request has already been submitted). [PASSED]
		3) Try to close a discarded review request. (Marked the review request as submitted) [PASSED]
		4) Push without a review request id in commit message. (Error logged that the request id does not exist). [PASSED]
		5) Push with a non existent request id in the commit message. (Error logged as Review request id does not exist.) [PASSED]
~		6) While trying to test feature implemented in rr #5666, I found that it wasn't working because the commit id for the review request was not updated on reviewboard backend. [FAILED]
	~	6) While trying to test feature implemented in rr #5666, I found that it wasn't working because the commit id for the review request was not updated on reviewboard backend. [FAILED]
-		7) Push a change with someone else's review request id in the commit message. Was able to close someone else's review request. [FAILED]

Commit:

+	7367cef3cf914c94f815f498d15bae0dd163680a

Diff:

Revision 4 (+58)

Show changes

reviewboard/hostingsvcs/bitbucket.py

Testing Done:

		Basic testing on a git repo performed. Test passed successfully (see screenshot).

		All tests carried out on both mercurial and git repos.

		Tests:
		1) Close an open review request. [PASSED]
		2) Try to close a review request that already has been closed as submitted. (Logged a warning saying that the review request has already been submitted). [PASSED]
		3) Try to close a discarded review request. (Marked the review request as submitted) [PASSED]
		4) Push without a review request id in commit message. (Error logged that the request id does not exist). [PASSED]
~		5) Push with a non existent request id in the commit message. (Error logged as Review request id does not exist.) [PASSED]
	~	5) Push with a non existent request id in the commit message. (Error logged as Review request id does not exist.) [PASSED]
-		6) While trying to test feature implemented in rr #5666, I found that it wasn't working because the commit id for the review request was not updated on reviewboard backend. [FAILED]

reviewboard/hostingsvcs/bitbucket.py (Diff revision 4)
The issue has been resolved. Show all issues
```
You didn't add any logging, so this import can go away.
```
reviewboard/hostingsvcs/bitbucket.py (Diff revision 4)
The issue has been resolved. Show all issues
```
This isn't used.
```
reviewboard/hostingsvcs/bitbucket.py (Diff revision 4)
The issue has been resolved. Show all issues
```
This line isn't necessary.
```

reviewboard/hostingsvcs/bitbucket.py (Diff revision 4)

The issue has been resolved. Show all issues

If review_id_to_commits is an empty map, close_all_review_requests will be a no-op. Therefore I think you can remove the test and early return.

Change Summary:

Removed the unused imports and the check for review_id_to_commits_map to be None.

Commit:

-	7367cef3cf914c94f815f498d15bae0dd163680a
+	891b8357acc457c91f5a6d254b6083857d494c13

Diff:

Revision 5 (+50)

Show changes

reviewboard/hostingsvcs/bitbucket.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (9e4245e).