Summary

Attempt to make directories writable on rb-site upgrade.

Review Request #5643 — Created March 17, 2014 and submitted April 1, 2014, 5:07 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

Commit

55ebefa...

Reviewers

Groups

reviewboard

People

Description

When upgrading an existing site, there should be at least one directory
("uploaded") that is writable by the web server. We can use this as a
reference point for all other directories that need to be made writable.

We now stat that directory and change ownership of all the other
directories.

I've also added uploaded/files as a generated directory. Technically,
this can be created on-the-fly, but since we know we want it, and make
the other directories, we may as well make this one up-front.

Testing Done

Created a site. Changed the ownership of a directory, and removed another.
Upgraded the site, and saw the expected permissions.

Issues

Description	From	Last Updated
If you reorder these, you could move the mkdir into the other loop.	david	April 1, 2014, 4:06 p.m.
Should we log something here?	david	April 1, 2014, 3:59 p.m.

reviewboard/cmdline/rbsite.py (Diff revision 1)

The issue has been resolved. Show all issues

If you reorder these, you could move the mkdir into the other loop.

chipx86 March 18, 2014, 1:30 p.m.

How do you mean?

The stat will fail if the uploaded directory doesn't already exist. I suppose I could do a separate mkdir for the uploaded directory, then stat, then do the mkdir + chown?

david March 18, 2014, 4:56 p.m.
```
Yeah, I think that would be nice.
```

reviewboard/cmdline/rbsite.py (Diff revision 1)

The issue has been dropped. Show all issues

Should we log something here?

chipx86 March 18, 2014, 1:30 p.m.

I don't think we need to. This is just a nice helpful thing. If they need to change ownership at install, they'll be told at the end of the install process. If it's an upgrade, they should only hit an error if they're not using a root user, in which case they'll just be told in the Manual Updates check (complete with instructions).