Update Review Board for the DataGrid state changes.

 






 

 


  Review Request #5613
  —
  Created March 11, 2014 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  Review Board
 









 
 

  release-2.0.x
 









 
 

  
 









 
 

  
 









 
 

  54a1a93...
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
Datagrids now have a separation of state and definition. This requires

some changes in Column subclasses to make use of the new state

parameters.


As part of the new fixes, we're also able to fix sorting of the review

request ID column, which broke in RC 1.

 








  


 
 

  
Unit tests pass.


Added every column. Rearranged columns. Sorted several of them. Removed columns.

Everything worked.


Tested the review request ID column with both global review requests and Local Sites.

 







 









 





  








 




 







   

    
    

    

    


    


      

       
      

    

    

   

  

 





    


    

    





     
    
    
    
   
    
  
    
  
    
   
   Loading...