Fix a bunch of jshint errors, generalize tests.

Review Request #5595 — Created March 7, 2014 and submitted

Information

Review Board
release-2.0.x
3a1cfda...

Reviewers

This change fixes a bunch of errors found by jshint. Most of these are silly
things like missing semicolons. This also changes our use of 'public' to
always use string notation, so that we're not using a reserved word.

When I was running the js-tests, I found that different browsers used different
orders for attrs which had been added from javascript when calling .html().
This meant that several of our field tests broke when running in firefox. I've
changed this to test more generally instead of looking for specific html
strings.

Ran js-tests.

chipx86
  1. Looks good.

    We may want to consider renaming public to isPublic.

    1. I considered that but this seemed like a safer change to make.

  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (3956631).
Loading...