User manual part 3: Update "Reviewing Diffs"

Review Request #5545 — Created Feb. 25, 2014 and submitted

Information

Review Board
release-2.0.x

Reviewers

User manual part 3: Update "Reviewing Diffs"

This change adds a bunch of new content for the "Reviewing Diffs" page to
explain several of our coolest diff viewer features. This also rewrites some of
the text to be clearer, and replaces all of the old screenshots with both 1x
and 2x screenshots of the modern UI.

Built the HTML manual and looked at all the pretty things.

Description From Last Updated

Two blank lines.

chipx86chipx86

This is less a concern now. Not sure if we want to just scrap this note, but if not, we …

chipx86chipx86
chipx86
  1. 
      
  2. docs/manual/users/reviews/reviewing-diffs.rst (Diff revision 1)
     
     
     
     
    Show all issues

    Two blank lines.

  3. docs/manual/users/reviews/reviewing-diffs.rst (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
    Show all issues

    This is less a concern now. Not sure if we want to just scrap this note, but if not, we should change it to say that this may happen in lines immediately around changed lines in diffs.

    1. I think I'd rather leave it as-is. It's worded a little strongly given the nature of the remaining issues, but it does still apply, and this way it will still be there for people who end up on this version of the manual instead of the 1.x versions.

  4. 
      
david
chipx86
  1. Ship It!

  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to release-2.0.x (3959f85).