Add support for change descriptions in drafts

Review Request #553 — Created Sept. 18, 2008 and submitted

chipx86
Review Board SVN (deprecated)
trunk
333
reviewboard
This change adds initial support for change descriptions for review request drafts. When the user goes to make a change, they can optionally add text describing what changed.

Changes made (with or without accompanying text) will be displayed on the review request page, allowing users to see that, for example, a new diff has been uploaded.

Further improvements down the road include showing thumbnails of changed screenshots and offering interdiff links for the new diff.
Made all kinds of changes to review requests and saw the expected results on each. The unit tests also pass.

Selenium tests down the road will help verify that this works as expected.
david
  1. Most of this looks excellent.  I'd like to see some more detail in your description about the implementation and the tests you've added.
  2. /trunk/reviewboard/reviews/models.py (Diff revision 1)
     
     
    Can you get rid of this blank line?
  3. /trunk/reviewboard/reviews/models.py (Diff revision 1)
     
     
    Can you get rid of this blank line?
  4. /trunk/reviewboard/reviews/models.py (Diff revision 1)
     
     
    if not review_request:
  5. 
      
Loading...