Tweak the account forms a bit.

Review Request #5526 — Created Feb. 21, 2014 and submitted

Information

Review Board
release-2.0.x
9297507...

Reviewers

The forms on "My Account" had a few issues. The first one I noticed was that
the label for "Keep this information private" ended with a colon, despite the
check-box being on the left side of the label. This was because we were using
django's label_tag method, which is kind of dumb and expects the form field to
always be on the right-hand side of the label. I've switched us over to using
djblets' label_tag tag, which does the right thing for check-boxes. As a nice
side-effect, we automatically get better styling for required field labels.

The other thing I noticed was some issues with alignment and sizing. The labels
were all indented 0.5em from the left-hand side of the boxes that they labeled,
which looked ugly. The e-mail field also had a different font size than the
other fields.

Looked at the various forms in "My Account" and saw that they all looked nice.


Description From Last Updated

Why is E-mail address bold, when the others aren't? Can we add back some of the vertical padding?

chipx86chipx86
chipx86
  1. 
      
  2. Why is E-mail address bold, when the others aren't?

    Can we add back some of the vertical padding?

    1. It's because it's a required field and the others aren't (and it's picking up an old CSS rule from common.less that makes things bold). I'll change things to look like our review request page.

  3. 
      
david
chipx86
  1. Ship It!

  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (a6c1dd7).
Loading...