Summary

Execute subcommands using the "C" locale.

Review Request #5498 — Created Feb. 18, 2014 and submitted Feb. 18, 2014, 4:29 p.m.

Information

Owner

david

Repository

RBTools

Branch

release-0.5.x

Bugs

3253

Depends On

Commit

cb37bd6...

Reviewers

Groups

rbtools

People

Description

Execute subcommands using the "C" locale.

A while back, we changed rbtools to exec the various command-line tools it uses
using the en_US locale (so that we wouldn't get diffs with localized strings in
them). This is nice, but annoying when users don't have the en_US locale on
their system. This change updates things to use the "C" locale instead.

Testing Done

Ran unit tests.

Ship it!

This is triggering some memory... I don't remember if it was RBTools or something at VMware, but something broke, or maybe got very slow, when we forced to "C".

Probably VMware... Do you happen to remember?

david Feb. 18, 2014, 4:27 p.m.

Digging through ancient history, we never had it set to "C". The patch that introduced en_US did so directly (before then we never specified a locale). If there are tools that break or get very slow then there's some huge problem with the world and I'm quitting programming.

chipx86 Feb. 18, 2014, 4:38 p.m.

Every so often, I want to hit Like on a comment.

1tush April 20, 2014, 10:20 a.m.

Unfortunately, this change made impossible to get any localized strings from VCS commit comment. They are displayed as '?????' instead of '??????'.

Status:: Completed
Change Summary:: Pushed to release-0.5.x (7bf376c).