• 
      

    Show RRs from inactive users on "All Review Requests" and their user page.

    Review Request #5488 — Created Feb. 17, 2014 and submitted — Latest diff uploaded

    Information

    Review Board
    master
    192ee06...

    Reviewers

    Show RRs from inactive users on "All Review Requests" and their user page.

    Long ago we made a change that hid review requests from inactive users from the
    dashboard. Unfortunately, this went way too far, hiding them from all
    datagrids, including "All Review Requests" and their user page. As funny as it
    is to "disappear" someone when they leave the company, it does make it harder
    for people who are trying to find old changes.

    • Set a user who had a couple old review requests as inactive. Saw that I could
      now see their changes in /r/ and /users/<user>/. Verified that their pending
      changes were still hidden from my dashboard.
    • Ran unit tests.