-
-
reviewboard/diffviewer/models.py (Diff revision 1) Are line numbers 1-based or 0-based for this error?
(Wish we had that in a docstring for the class.)
I also had to look up what the 1 was for. Can you use a keyword argument?
-
reviewboard/diffviewer/models.py (Diff revision 1) Comma instead of
%?Do we want to use
exc_info=1? Might not be useful enough to us, but shrug.
Handle parse errors during diff migration.
Review Request #5485 — Created Feb. 16, 2014 and submitted
Handle parse errors during diff migration.
The new diff size column would cause migrations for old diff data. In the case
where a very old review request has un-migrated data which doesn't parse
correctly (from back when you could attach a bogus diff to a review request),
it would cause an un-caught exception. This change handles DiffParseErrors in
the recalculate_line_counts method.
Ran unit tests.
| Description | From | Last Updated |
|---|---|---|
|
Are line numbers 1-based or 0-based for this error? (Wish we had that in a docstring for the class.) I … |
 chipx86
|
|
|
Comma instead of %? Do we want to use exc_info=1? Might not be useful enough to us, but shrug. |
chipx86
|
|
|
This will cause format string problems. Shouldn't have the parens. |
chipx86
|
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+10 -5) |
-
-
reviewboard/diffviewer/models.py (Diff revisions 1 - 2) This will cause format string problems. Shouldn't have the parens.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+10 -5) |