[WIP] Diff Incremental Expansion for Reviews on Review page

 






 

 


  Review Request #5480
  —
  Created Feb. 15, 2014 and discarded  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  edwinzg
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard, students
 









 
 

  
 






 








 





  


 
 

  
Getting familiar with the code and what affects what for the diff incremental expansion on the reviews page.


Started trying to add an expand below, but running into some errors

In terminal this error: [23/Feb/2014 19:00:21] "GET /r/2/fragments/diff-comments/2,1,3/?queue=diff_fragments&container_prefix=comment_container&1393181991 HTTP/1.1" 500 1376


In Chrome developer tools: GET http://localhost:8080/r/2/fragments/diff-comments/2,1,3/?queue=diff_fragments&container_prefix=comment_container&1393181991 500 (INTERNAL SERVER ERROR) linking to diffFragmentQueueView.js:69


Fixed the 500 errors so the button to expand the diff appears, now working on functionality.


Trying to add the functionality, but it's not working, I think it may be with either the context['chunk'] or the context['file'] that I'm passing in.

 








  


 
 

  

 







 









 





  








 




 







   

    
    

    

    


    


      

       
      

    

    

   

  

 





    


    

    





     
    
    
    
   
    
  
    
  
    
   
   Loading...