Add a "Diff Size" column to the dashboard.
Review Request #5478 — Created Feb. 15, 2014 and submitted
Information | |
---|---|
david | |
Review Board | |
master | |
48 | |
a38bb18... | |
Reviewers | |
reviewboard | |
Add a "Diff Size" column to the dashboard.
This change adds a new column to our Review request datagrids that shows an
approximate size for the diff (added and removed lines). It doesn't correspond
very directly to what users will see in the diff viewer, but it should be good
enough to give a general sense of how big the patch is.
Added the column to my dashboard when running a dump of the
reviews.reviewboard.org database. Saw nice diff sizes for all changes that
included a diff, and nothing for attachment-only review requests.
Change Summary:
Add a space between the added and removed spans.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+46) |
-
-
reviewboard/datagrids/columns.py (Diff revision 1) Should be < 80 columns.
Also, can you add blank lines around the if blocks?
-
reviewboard/static/rb/css/dashboard.less (Diff revision 1) Blank line between these.
.delete
should be beforeinsert
.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+50) |