Add a "Diff Size" column to the dashboard.

 






 

 


  Review Request #5478
  —
  Created Feb. 15, 2014 and submitted 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  master
 









 
 

  48
 









 
 

  
 









 
 

  a38bb18...
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
Add a "Diff Size" column to the dashboard.


This change adds a new column to our Review request datagrids that shows an

approximate size for the diff (added and removed lines). It doesn't correspond

very directly to what users will see in the diff viewer, but it should be good

enough to give a general sense of how big the patch is.

 








  


 
 

  
Added the column to my dashboard when running a dump of the

reviews.reviewboard.org database. Saw nice diff sizes for all changes that

included a diff, and nothing for attachment-only review requests.

 







 









 





  








 

  
  


   

    

     

     

     

    

   


   

    

     

     

     

    

   


   

  

 







 
 
 

  

   

    

     
    

    
    
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
    

   

   

    
     

      Description
      From
      Last Updated
     

    
    



     

      
       
       
Can we try it with a space between the numbers?

      		
      
       chipx86chipx86
      
      
       
      
     




     

      
       
       
Should be < 80 columns. Also, can you add blank lines around the if blocks?

      		
      
       chipx86chipx86
      
      
       
      
     




     

      
       
       
Blank line between these. .delete should be before insert.

      		
      
       chipx86chipx86
      
      
       
      
     




     

      
       
       
Alignment issues.

      		
      
       chipx86chipx86
      
      
       
      
     


    
   

  

 







 






  

 








 














 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 














  2. 
 
    
  
  
    
  
 
    
  
   diff size column.png

  


  
    Can we try it with a space between the numbers?
    


 
    

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Can we try it with a space between the numbers?
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      I did that first. It made it slightly more readable but also wider. I'll add a screenshot of that.
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      I think I like the new one better. It's not too much wider, especially compared to some of our other columns.
      
 
      

      3. 


 
    


    

 
    

    3. 







  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




david




   

   

  

 



 















 



 

  

   




david




   

   

  

 



 















 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      reviewboard/datagrids/columns.py
      


       (Diff revision 1)


      
     
    
    
       
   
    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Should be < 80 columns.
    

    Also, can you add blank lines around the if blocks?
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      Looks like you reviewed the older revision of the diff.
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      Woops. :/
      
 
      

      3. 


 
    


    

 
    

    3. 






  3. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      reviewboard/static/rb/css/dashboard.less
      


       (Diff revision 1)


      
     
    
    
       
   
    
     
    

    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Blank line between these.
    

    .delete should be before insert.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  4. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    5. 




  

 
















 



 

  

   




david




   

   

  

 



 















 





 

  

   




chipx86




   

   









  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    One small regression in this change. After that, ship it!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      reviewboard/datagrids/columns.py
      


       (Diff revision 3)


      
     
    
    
       
   
    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Alignment issues.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




david




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 




 
Change Summary:

 
Pushed to master (7ba68fe).





 


 










  

 









     

    

   

  

  

   
   Loading...