-
-
reviewboard/hostingsvcs/beanstalk.py (Diff revision 1) Looking at _api_get, it looks like it will always return something, unless it raises an Exception.
So are we waiting for response to be the empty string here as our exit condition?
If that's the case, that sounds fragile (it makes us vulnerable to changes in Beanstalk's API that might put us in an infinite loop, if I'm understanding this correctly).
[WIP] HostingServices: add implementation of get_remote_repositories for Beanstalk
Review Request #5469 — Created Feb. 13, 2014 and discarded
| Information | |
|---|---|
| olessia | |
| Review Board | |
| master | |
| Reviewers | |
| reviewboard, students | |
| chipx86 | |
HostingServices: add implementation of get_remote_repositories for Beanstalk
Manual testing
| Description | From | Last Updated |
|---|---|---|
|
Looking at _api_get, it looks like it will always return something, unless it raises an Exception. So are we waiting … |
 mike_conley
|
|
|
No space before the """ |
 chipx86
|
|
|
This can probably just be one line. |
chipx86
|
|
|
Blank line before for loops. |
chipx86
|
|
|
type is a reserved word. For consistency, how about scm_type? |
chipx86
|
|
|
type is a reserved word. |
chipx86
|
|
|
We try to keep the statements simpler. Can you have a separate statement for setting mirror_path to None? Or just … |
chipx86
|
|
|
Blank lines around if statements. |
chipx86
|
OL
Change Summary:
The beanstalk api is currently limited, but they are working on version 2 that will have better support for pagination.
Testing Done: |
|
||||||
|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+22) |
-
-
-
-
-
reviewboard/hostingsvcs/beanstalk.py (Diff revision 2) typeis a reserved word. For consistency, how aboutscm_type? -
-
reviewboard/hostingsvcs/beanstalk.py (Diff revision 2) We try to keep the statements simpler. Can you have a separate statement for setting
mirror_pathto None?Or just set it below when yielding, actually.
-