Fix displaying of large images in thumbnails and image pages for review requests

Review Request #5444 — Created Feb. 9, 2014 and submitted

tamijo
Review Board
master
reviewboard, students

Large images, or images wider than the width of the thumbnail boxes on review request pages were overflowing the size of their bounding boxes. I updated their width to not exceed the parent divs

Tested this on my local server using images from the reviewboard server that overflowed their bounding boxes.

Loading file attachments...

Description From Last Updated

This looks like a good idea to me. Do we use @file-attachment-width anywhere else? If so, we can probably axe ...

mike_conleymike_conley
mike_conley
  1. 
      
  2. reviewboard/static/rb/css/reviews.less (Diff revision 1)
     
     

    This looks like a good idea to me. Do we use @file-attachment-width anywhere else? If so, we can probably axe it. If not, feel free to drop this issue.

    1. @file-attachment-width is used to set the width of the actual box at lines 909-910 - do you mean I should get rid of that?

    2. Nah, I thought maybe it was being used to just constrain the width of the image. We're good here.

  3. 
      
mike_conley
  1. This looks good to me - thanks Tami!

  2. 
      
TA
Review request changed

Status: Closed (submitted)

Change Summary:

Thanks! b48a7b8d
Loading...