Summary

Fix displaying of large images in thumbnails and image pages for review requests

Review Request #5444 — Created Feb. 9, 2014 and submitted Feb. 9, 2014, 9:45 a.m.

Information

Owner

tamijo

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard, students

People

Description

Large images, or images wider than the width of the thumbnail boxes on review request pages were overflowing the size of their bounding boxes. I updated their width to not exceed the parent divs

Testing Done

Tested this on my local server using images from the reviewboard server that overflowed their bounding boxes.

Files

Issues

Description	From	Last Updated
This looks like a good idea to me. Do we use @file-attachment-width anywhere else? If so, we can probably axe …	mike_conley	Feb. 9, 2014, 9:20 a.m.

reviewboard/static/rb/css/reviews.less (Diff revision 1)

The issue has been dropped. Show all issues

This looks like a good idea to me. Do we use @file-attachment-width anywhere else? If so, we can probably axe it. If not, feel free to drop this issue.

tamijo Feb. 9, 2014, 9:16 a.m.

@file-attachment-width is used to set the width of the actual box at lines 909-910 - do you mean I should get rid of that?

mike_conley Feb. 9, 2014, 9:20 a.m.

Nah, I thought maybe it was being used to just constrain the width of the image. We're good here.

Ship it!

```
This looks good to me - thanks Tami!
```

Status:: Completed
Change Summary:: Thanks! b48a7b8d