Fix problems with the "New updates" flags showing up too often.

Review Request #5438 — Created Feb. 8, 2014 and submitted

Information

Djblets
master

Reviewers

Fix problems with the "New updates" flags showing up too often.

When replying to a review, if one waited long enough, they'd see a bubble pop
up that said "New updates by me". The issue here was that we were setting the
last updated time to be a time that included milliseconds, and then we'd later
fetch the last-update resource, which would give us a time that didn't include
milliseconds. Since those didn't match, we'd show the updates bubble.

I've changed the API encoder to never include milliseconds in serialized
datetimes. This makes it so that the data we send after saving a new datetime
field to the database is the same data we send after reading it back from the
database.

  • Replied to a review and saw that it was setting the lastUpdated time to a
    timestamp that didn't include milliseconds. Waited to see it do a
    last-updated check and didn't see the updates bubble.
  • Ran djblets unit tests.
  • Ran reviewboard unit tests.
chipx86
  1. Can you also run the Djblets and Review Board unit tests, just to make sure everything still serializes fine?

  2. 
      
david
chipx86
  1. Ship It!

  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (d0fc039).
Loading...