Fix for an IntegrityError when trying to load the dashboard

Review Request #5435 — Created Feb. 8, 2014 and submitted

b.ramnani
Review Board
master
reviewboard
chipx86, david, smacleod

When trying to load the dashboard using the datagrids module, the profile was not passed as a parameter to the site_profile property.

Tried to open the dashboard in the logged in as well as the logged out state to check if the error appears again. Also registered as a new user and saw whether the issue occurs.

chipx86
  1. Code looks fine. These comments are more about the process of creating a review request.

    It's important to always fill in the Testing Done, so we have a good idea of what you've done to ensure this doesn't break.

    We also always like to hear that unit tests were part of the testing.

    Also, the summary sounds like a bug report. It should be more like "Fix an IntegrityError ..."

  2. 
      
mike_conley
  1. Hey Bhushan - any updates on this?

  2. 
      
B.
david
  1. Ship It!

  2. 
      
B.
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (a5f8197). Thanks!
Loading...