Summary

Show diff/interdiff links from rbt post output

Review Request #5434 — Created Feb. 8, 2014 and submitted Feb. 8, 2014, 2:41 p.m.

Owner

Repository

RBTools

Branch

master

Bugs

Depends On

Groups

People

Description

This will add the diff url to the rbt command line after the review request url and it fixes the issue 2929.

Testing Done

I have tested this multiple times on my command line, when posting review request via rbt. I also attached pic about the test case.

Files

Issues

Description	From	Last Updated
Trailing whitespace.	chipx86	Feb. 8, 2014, 1:59 p.m.
You don't need the 'r' in front of the string.	chipx86	Feb. 8, 2014, 1:59 p.m.
In general, "url" should be "URL" in strings. I think these would look better though as: Review request: <URL HERE> …	chipx86	Feb. 8, 2014, 1:59 p.m.
blaablaaa blaalalalalala sdfasfdsf	AU Audore	Feb. 8, 2014, 3:56 p.m.

We don't handle TIFF review. Can you put up a PNG screenshot instead?

rbtools/commands/post.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Trailing whitespace.
```
rbtools/commands/post.py (Diff revision 1)
The issue has been resolved. Show all issues
```
You don't need the 'r' in front of the string.
```

rbtools/commands/post.py (Diff revision 1)

The issue has been resolved. Show all issues

In general, "url" should be "URL" in strings.
I think these would look better though as:
Review request: <URL HERE>
Diff: <URL HERE>

I made changes made according to the issues raised. Also added .png picture of the test case I ran.

+	master

Ship it!

Pushed to master (e3444e7). Thanks!

Thanks! I accidentally mixed this with the development environment... that's what the comment was about.

rbtools/commands/post.py (Diff revision 2)
The issue has been dropped. Show all issues
```
blaablaaa blaalalalalala sdfasfdsf
```