Show diff/interdiff links from rbt post output

Review Request #5434 — Created Feb. 8, 2014 and submitted

Audore
RBTools
master
rbtools, students
david

This will add the diff url to the rbt command line after the review request url and it fixes the issue 2929.

I have tested this multiple times on my command line, when posting review request via rbt. I also attached pic about the test case.


Description From Last Updated

Trailing whitespace.

chipx86chipx86

You don't need the 'r' in front of the string.

chipx86chipx86

In general, "url" should be "URL" in strings. I think these would look better though as: Review request: <URL HERE> ...

chipx86chipx86

blaablaaa blaalalalalala sdfasfdsf

AU Audore
chipx86
  1. We don't handle TIFF review. Can you put up a PNG screenshot instead?

  2. 
      
chipx86
  1. 
      
  2. rbtools/commands/post.py (Diff revision 1)
     
     

    Trailing whitespace.

  3. rbtools/commands/post.py (Diff revision 1)
     
     

    You don't need the 'r' in front of the string.

  4. rbtools/commands/post.py (Diff revision 1)
     
     
     

    In general, "url" should be "URL" in strings.

    I think these would look better though as:

    Review request: <URL HERE>
    Diff: <URL HERE>
    
  5. 
      
AU
david
  1. Ship It!

  2. 
      
AU
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (e3444e7). Thanks!
AU
  1. 
      
    1. Thanks! I accidentally mixed this with the development environment... that's what the comment was about.

  2. rbtools/commands/post.py (Diff revision 2)
     
     

    blaablaaa blaalalalalala sdfasfdsf

  3. 
      
Loading...