This change has been marked as completed.

Describe the completed change (optional):

Pushed to master (e3444e7). Thanks!

Summary

Show diff/interdiff links from rbt post output

Review Request #5434 — Created Feb. 8, 2014 and submitted 11 years, 2 months ago

Information

Owner

Audore*

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools, students

People

david

Description*

This will add the diff url to the rbt command line after the review request url and it fixes the issue 2929.

Testing Done

I have tested this multiple times on my command line, when posting review request via rbt. I also attached pic about the test case.

Files

test_diff_url.png

Issues

Description	From	Last Updated
Trailing whitespace.	chipx86	11 years, 2 months ago
You don't need the 'r' in front of the string.	chipx86	11 years, 2 months ago
In general, "url" should be "URL" in strings. I think these would look better though as: Review request: <URL HERE> …	chipx86	11 years, 2 months ago
blaablaaa blaalalalalala sdfasfdsf	AU Audore	11 years, 2 months ago
There are no open issues

We don't handle TIFF review. Can you put up a PNG screenshot instead?

rbtools/commands/post.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Trailing whitespace.
```
rbtools/commands/post.py (Diff revision 1)
The issue has been resolved. Show all issues
```
You don't need the 'r' in front of the string.
```

rbtools/commands/post.py (Diff revision 1)

The issue has been resolved. Show all issues

In general, "url" should be "URL" in strings.
I think these would look better though as:
Review request: <URL HERE>
Diff: <URL HERE>

Change Summary:

I made changes made according to the issues raised. Also added .png picture of the test case I ran.

Branch:

master

Diff:

Revision 2 (+4 -1)

Show changes

rbtools/commands/post.py

Removed Files:

Download

test_rbt_post.tiff

Added Files:

test_diff_url.png

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (e3444e7). Thanks!

Audore 11 years, 2 months ago

Thanks! I accidentally mixed this with the development environment... that's what the comment was about.

rbtools/commands/post.py (Diff revision 2)
The issue has been dropped. Show all issues
```
blaablaaa blaalalalalala sdfasfdsf
```