Fix for issue 3006: add password verification when creating new site

Review Request #5424 — Created Feb. 7, 2014 and submitted

Information

Review Board
master

Reviewers

When creating new sites using rb-site install on the command-line, no entered passwords were being verified. If passwords were re-entered incorrectly, it accepted it, completed all the actions, and on the final step reported that the passwords were wrong and aborted installation.
Now after passwords are first entered, the confirmation prompt makes sure that the re-entered password matches the first.
In addition, passwords were printed out to the command line as a default value after the first prompt. This has been removed.


 
Description From Last Updated

There should only be one blank line between methods.

daviddavid
david
  1. I haven't looked at the code yet, but I'd like you to rewrite your description. The summary is good, but the description should explain what the bug is and how we're fixing it. The goal is that when looking back through the commit history, we can know what a change is about without having to click over to the bug tracker.

    You can also put the bug number into the "Bugs" field on the right, instead of including your own link.

  2. reviewboard/cmdline/rbsite.py (Diff revision 1)
     
     
     
    Show all issues

    There should only be one blank line between methods.

  3. 
      
TA
TA
david
  1. Ship It!

  2. 
      
TA
  1. Ship It!

  2. 
      
TA
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (0341b58). Thanks!
Loading...