Looks good. Committed as r1505.
Small fix in post-review for an issue ocurring in some svn repos when submitting any review.
Review Request #536 — Created Sept. 10, 2008 and submitted
|Review Board SVN (deprecated)|
Fix for an issue that was happening in *some* boxes working with an svn repo: submitting a review with post-review always ended with an error ("Error uploading diff: One or more fields had errors (105). Your review request still exists, but the diff is not attached."), see thread http://groups.google.com/group/reviewboard/browse_thread/thread/f7526413d38770b5 Terry Rankine found the reason behind this: The command that issues svn info - has funky end of line characters, which makes the decoding of the base url wrong, which makes the replace slashes command wrong, which leads to a diff which is missing the lead slashes, which leads to the diff being wrong. And it gets fixed just by stripping incoming values in svn_info.