Issue 3200:"Depends on" field now uses strikethrough for submitted dependencies.

Review Request #5348 — Created Jan. 29, 2014 and submitted

olessia
Review Board
master
3200
students

The "Depends on" field is used to indicate when one change depends on another. It would be very useful if it could react when those dependencies are marked as submitted by setting a strikethrough on the text. That way, users don't have to click through to see whether or not the dependent change has been committed yet.

Manual testing: marked a dependency submitted, observed it show up with a linethrough in the "Depends On" list for another review.
All tests in djblets and reviewboard pass.

Description From Last Updated

Indentation/alignment's a bit off now. Since this is going to end up being over 80 if you fix the alignment, ...

chipx86chipx86

After thinking about this and doing some reading, I think this should be <s>: <ins> and <del> are for showing ...

chipx86chipx86
OL
chipx86
  1. 
      
  2. reviewboard/reviews/builtin_fields.py (Diff revision 1)
     
     
     

    Indentation/alignment's a bit off now.

    Since this is going to end up being over 80 if you fix the alignment, I'd suggest:

    rendered_item = (
        '<a href ...'
        % (...))
    
  3. 
      
chipx86
  1. 
      
  2. reviewboard/reviews/builtin_fields.py (Diff revision 1)
     
     

    After thinking about this and doing some reading, I think this should be <s>:

    <ins> and <del> are for showing editorial changes, generally to an already published page. The <s> element is for indicating information that is no longer relevant or accurate, but still provides some value, and is generally used to create a document with both old and new information at the same time.

    • http://html5doctor.com/ins-del-s/
  3. 
      
OL
david
  1. Ship It!

  2. 
      
OL
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (9e57cc2). Thanks!
Loading...