Summary

Fix review counts when deleting repositories.

Review Request #5343 — Created Jan. 28, 2014 and submitted Jan. 29, 2014, 2:26 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

3192

Depends On

Reviewers

Groups

reviewboard

People

Description

Fix review counts when deleting repositories.

Removing repositories through the admin UI was hopefully the last place that
could leave the review counts out of date. Unfortunately, there's no good way
to get signalled when doing cascaded delete operations, because it's handled
entirely by the SQL server.

This change overrides ModelAdmin.log_deletion to fix up the review counts after
deleting one or more repositories.

Testing Done

Removed repositories that had review requests both using the individual and
bulk delete operations. Reloaded my dashboard and saw that the review counts
were correct.

Issues

Description	From	Last Updated
Can just take args, *kwargs and pass that in instead, so we never have to worry about them changing arguments.	chipx86	Jan. 29, 2014, 2:19 p.m.
""" on the next line.	chipx86	Jan. 29, 2014, 2:19 p.m.

We can't listen to the deletion signal for the model? I assumed we'd get that any time we'd also get a log_deletion.

reviewboard/scmtools/admin.py (Diff revision 1)

The issue has been dropped. Show all issues

Can just take *args, **kwargs and pass that in instead, so we never have to worry about them changing arguments.

reviewboard/scmtools/admin.py (Diff revision 1)
The issue has been resolved. Show all issues
```
""" on the next line.
```

Change Summary:

Switch to using pre_delete.

Diff:

Revision 2 (+31 -9)

Show changes

	reviewboard/accounts/admin.py
	reviewboard/reviews/management/commands/fixreviewcounts.py
	reviewboard/scmtools/admin.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (428b29f).