Filter out replies when calculating issue counts.

Review Request #5319 — Created Jan. 24, 2014 and submitted

Information

Review Board
master

Reviewers

Filter out replies when calculating issue counts.

Issue counts on review requests were going up when replies were made to
comments with issues. This happened because we looked for all comments,
and not just top-level comments, when calculating issue counts and when
deciding whether to increase issue counts.

We now limit these only to top-level reviews/comments.

I also noticed that we were bumping the last review activity timestamp
even when a review was still in draft mode. That's been fixed so that
the value is only updated when the review is public.

Unit tests pass.

Replied to a comment, and didn't see the count go up.

Description From Last Updated

Indentation is a bit wacky here.

daviddavid
david
  1. 
      
  2. reviewboard/reviews/models/base_comment.py (Diff revision 1)
     
     
     
    Show all issues

    Indentation is a bit wacky here.

  3. 
      
chipx86
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Loading...