Summary

Bump django dependency to 1.6

Review Request #5310 — Created Jan. 23, 2014 and submitted Feb. 3, 2014, 12:57 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Bump django dependency to 1.6

This change updates our django dependency to >= 1.6.1.

With the previous change to make sure that initialize() is called from test
setUp() methods, this is pretty small: * Update the hg and bzr tests to properly detect missing dependencies and skip
tests as appropriate. * Remove the django.contrib.markup app. We got rid of our usage of this a while
ago and forgot to remove it from INSTALLED_APPS. In Django 1.6 it's been
removed entirely. * Change the setup.py check to reject Python 2.6 versions less than 2.6.5. * Fix call to compile_messages() in build-i18n.py

Testing Done

Ran unit tests.

Change Summary:

Update to not include the test changes.

The hg/bzr stuff and django.contrib.markup changes can probably be pulled out into their own commits too, leaving this to be very small. I'll do that next.

Description:

		Bump django dependency to 1.6

		This change updates our django dependency to >= 1.6.1.

~		The bulk of this change is to make sure that we call `initialize()` inside our
~		test case setup function. It turns out that the test `Client.login()` method no
~		longer uses a request, which means that our middleware that loads the
~		siteconfig isn't guaranteed to run. For one of our tests, it was hitting the
~		case that the user would be authenticated against ModelBackend, and then when
~		we tried to do an actual request, it would load the siteconfig, replacing
~		`settings.AUTHENTICATION_BACKENDS`. Once this happened, it would check that
~		`user.backend` was in the loaded backends, and when it wasn't, set `request.user`
	~	With the previous change to make sure that `initialize()` is called from test
	~	`setUp()` methods, this is pretty small:
	~	* Update the hg and bzr tests to properly detect missing dependencies and skip
	~	tests as appropriate.
	~	* Remove the `django.contrib.markup` app. We got rid of our usage of this a while
	~	ago and forgot to remove it from `INSTALLED_APPS`. In Django 1.6 it's been
	~	removed entirely.
	~	* Change the setup.py check to reject Python 2.6 versions less than 2.6.5.
-		to be `AnonymousUser`.
-
-		I've solved this issue by calling `initialize()` inside `TestCase.setUp()`. A lot
-		of our TestCase subclasses weren't calling the super class' `setUp()`, so I've
-		fixed that.

Diff:

Revision 2 (+13 -7)

Show changes

	setup.py
	reviewboard/settings.py
	reviewboard/scmtools/hg.py
	reviewboard/scmtools/tests.py

Change Summary:

Include fix for compile_messages()

Description:

		Bump django dependency to 1.6

		This change updates our django dependency to >= 1.6.1.

		With the previous change to make sure that `initialize()` is called from test
~		`setUp()` methods, this is pretty small:
	~	`setUp()` methods, this is pretty small:
		* Update the hg and bzr tests to properly detect missing dependencies and skip
~		tests as appropriate.
	~	tests as appropriate.
		* Remove the `django.contrib.markup` app. We got rid of our usage of this a while
		ago and forgot to remove it from `INSTALLED_APPS`. In Django 1.6 it's been
~		removed entirely.
~		* Change the setup.py check to reject Python 2.6 versions less than 2.6.5.
	~	removed entirely.
	~	* Change the setup.py check to reject Python 2.6 versions less than 2.6.5.
	+	* Fix call to `compile_messages()` in build-i18n.py

Diff:

Revision 3 (+14 -8)

Show changes

	setup.py
	contrib/internal/build-i18n.py
	reviewboard/settings.py
	reviewboard/scmtools/hg.py
	reviewboard/scmtools/tests.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (f299f74).