Add support for interdiffs

Review Request #53 — Created June 7, 2007 and submitted

Information

Review Board SVN (deprecated)
trunk

Reviewers

Added support for displaying interdiffs (diffs between revisions of diffs). This allows users to see what's changed between two versions of a diff.

This is not complete. Comments don't yet work (I'll be working on a change to how comments are stored which will allow them to work in interdiffs later). There's also some things that could use some cleaning up (faster logic in one spot, possibly hide unchanged files in the diff view). Due to this, I didn't expose any UI. It's still useful to look at, though.
Uploaded two revisions of a diff. The interdiff looked correct.
david
  1. Got a few simple comments.
  2. /trunk/reviewboard/diffviewer/views.py (Diff revision 1)
     
     
     
     
    How about:
    old, new = new, get_patched_file(old, interfilediff)
  3. /trunk/reviewboard/diffviewer/views.py (Diff revision 1)
     
     
    FIXME or XXX, please, for searchability.
    1. Kind of surprised I didn't do that originally.
  4. /trunk/reviewboard/urls.py (Diff revision 1)
     
     
     
     
     
     
    Do we really need a different URL here?  Can't we use /diff/x-y/ ?
    1. Yeah, guess we can.
  5. 
      
Loading...