Split accounts.forms into new modules.

Review Request #5299 — Created Jan. 22, 2014 and submitted

Information

Review Board
master

Reviewers

Split accounts.forms into new modules.

While working on the new My Account page, I hit some circular dependency
issues with forms and backends. These weren't new, it turns out, as we
had sprinkled imports in the PreferencesForm functions.

Rather than adding more of that, I decided to split this file up.
There's now three modules: account (for account-related forms),
registration, and auth (for auth backends).

Unit tests pass.

Tested that the registration form still worked.

Tested that the My Account page still worked.

Tested that auth backends loaded and saved in the Auth Settings page.

david
  1. Do you have an __init__.py in forms/ ?

    1. I do. We should really make RB not hide that.

    2. Old, old bug :(

  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed