Show open issues instead of Ship It! in the dashboard and reviews.

Review Request #5286 — Created Jan. 21, 2014 and submitted

Information

Review Board
master

Reviewers

Show open issues instead of Ship It! in the dashboard and reviews.

The dashboard now shows the number of open issues instead of the number
of Ship Its if there are open issues. If there are no open issues left,
the Ship Its are displayed instead. This makes it a lot easier to see at
a glance on the dashboard if a change is ready to go in, or if work
still needs to be done.

On a review box, "Ship it!" will be replaced by "Fix it, then Ship it!"
when there are open issues. As soon as they're all resolved for that
review, the text will be replaced by "Ship it!" Likewise, re-opening an
issue will flip the text back to "Fix it, then Ship It!"

Tested the dashboard with review requests containing Ship Its, those containing
just issues, and those with a mix.

Tested loading review boxes with Ship Its, with issues, and without either.

Tested changing issue states to clear all open issues and to reopen, and saw
that the Ship It tag changed.


Description From Last Updated

Can you make the exclamation point a little smaller and darker? It doesn't look like quite the same style as …

daviddavid

Just for clarity, can you change this to be if/elif/else?

daviddavid

Please move this out into its own method.

daviddavid
david
  1. I haven't read through the code yet, but this should have bug 2723.

  2. 
      
chipx86
david
  1. 
      
  2. Can you make the exclamation point a little smaller and darker? It doesn't look like quite the same style as the check-mark.

  3. reviewboard/reviews/datagrids.py (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     

    Just for clarity, can you change this to be if/elif/else?

  4. reviewboard/static/rb/js/views/reviewBoxView.js (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     

    Please move this out into its own method.

  5. 
      
chipx86
david
  1. Can you upload a new screenshot of the dashboard?

    1. Huh... I did, it just didn't record it in the change description. The Dashboard image on here is the new one.

      I'll poke around at the change descriptions...

  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

amohapatra
  1. 
      
  2. 
      
Loading...