• 
      

    Fix a bad assumption in the new binary file download logic.

    Review Request #5285 — Created Jan. 20, 2014 and submitted — Latest diff uploaded

    Information

    Review Board
    master

    Reviewers

    Fix a bad assumption in the new binary file download logic.

    The new logic for showing download icons for binary files made the bad
    assumption that there was a FileAttachment we could query. We'd fail if
    not.

    We now check if the attachment is truthy before attempting to get the
    URL.

    Didn't hit an error on these binary files.

    Unit tests pass.