• 
      

    Encode strings to UTF-8 before sending them to LDAP.

    Review Request #5272 — Created Jan. 17, 2014 and submitted

    Information

    Review Board
    master

    Reviewers

    Encode strings to UTF-8 before sending them to LDAP.

    According to the RFCs that I quickly browsed through, it looks like LDAP
    expects text to be encoded as UTF-8. This typically doesn't matter because most
    strings that we deal with for authentication are ASCII.

    In bug 2978, a user had an accent in their password, which meant they couldn't
    authenticate. This is easily fixed by encoding the strings first.

    Ran unit tests

    Description From Last Updated

    Can you put blank lines between each if statement? This is kind of hard to read.

    chipx86 chipx86
    chipx86
    1. 
        
    2. reviewboard/accounts/backends.py (Diff revision 1)
       
       
       
       
       
       
       
      Show all issues

      Can you put blank lines between each if statement? This is kind of hard to read.

    3. 
        
    david
    chipx86
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (a4852f6).