post-review: Option to update the changelist description with the review url.
Review Request #527 — Created Sept. 4, 2008 and discarded
|Review Board SVN (deprecated)|
Adds '-u' option to post-review. This will get the changelist description and update it with the review url created. Only perforce is supported.
Posted a review and verified that the changelist was updated with url
Two comments here: 1. It would be really nice if this could update an existing 'Review Url:' field. At VMware we have changeset templates with a bunch of fields in them; being able to add an empty field to the template and let post-review populate it would be awesome. 2. A more pythonic way of writing this is: if 'Review Url:' not in desc:
This won't work now because execute sets shell=False. It might be helpful to add some plumbing to plumb some stuff through to execute() such that you can dump the file into the pipe for stdin. This would also eliminate the need to write the file out to disk.