Fix --parent situation for mercurial.

Review Request #5265 — Created Jan. 15, 2014 and submitted

Information

RBTools
master

Reviewers

Fix --parent situation for mercurial.

The mercurial implementation was using --parent to specify the upstream branch,
when it really ought to have been using --tracking-branch. This made it very
hard to support using --parent to specify an intermediate branch between the
upstream and the tip when posting without explicit revisions.

This change fixes the MercurialClient to use --tracking-branch to override
the detected upstream branch, and then allows --parent to actually generate
parent diffs.

  • Ran unit tests.
  • Posted a diff using --parent to my local devserver.
Description From Last Updated

Should we use getattr here?

chipx86chipx86
chipx86
  1. Testing? It'd be awesome to have a unit test for this.

    Also, bug field.

    1. Hi

    2. This is a production server. Please use http://demo.reviewboard.org/ for testing.

  2. rbtools/clients/mercurial.py (Diff revision 1)
     
     
     
    Show all issues

    Should we use getattr here?

  3. 
      
david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (5a93bb8).
Loading...