Allow for using repository names with Subversion repositories in 0.5.x.

Review Request #5248 — Created Jan. 13, 2014 and submitted

Information

RBTools
release-0.5.x

Reviewers

Allow for using repository names with Subversion repositories in 0.5.x.

Repository names for Subversion repositories broke Subversion. On
0.5.x, the name is stuffed into the repository_url setting, which the
Subversion code assumes means we're operating on some possibly remote
repository.

The proper fix to separate out repository names and URLs is coming in
0.6, but for now, we check the repository_url whenever we use it to see
whether it's a URL or a name.

This is intended to stay only on the 0.5.x branch, and will not merge to
master.

Tested with a checkout I had that didn't path-match a remote repository.
Used --repository-url and REPOSITORY= with URLs and names to make sure
it did the right thing.

Unit tests pass.

Description From Last Updated

Can we call this SVN_URL_RE?

daviddavid

I don't think the explicit is not None comparison really adds anything here. Truthiness is good enough and more readable.

daviddavid
david
  1. 
      
  2. rbtools/clients/svn.py (Diff revision 1)
     
     
    Show all issues

    Can we call this SVN_URL_RE?

  3. rbtools/clients/svn.py (Diff revision 1)
     
     
    Show all issues

    I don't think the explicit is not None comparison really adds anything here. Truthiness is good enough and more readable.

  4. 
      
chipx86
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Loading...