Change Summary:
The repository name is now included properly when doing the post. My previous tests were
still falling back to scanned path-based matching.
Testing Done: |
|
|||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+50 -8) |
Review Request #5246 — Created Jan. 13, 2014 and submitted
Split up
--repository-url
andREPOSITORY
into new options/settings.
--repository-url
andREPOSITORY
had both previously allowed either a
path to be specified, or a repository name. We'd try for the name when
looking up a repository, but would try for the path in different ways
within the SCMClients. In the case of Subversion, this broke pretty
badly when using a repository name.Now
--repository-url
has been split into--repository-url
and
--repository
, whileREPOSITORY
has been split intoREPOSITORY_URL
and
REPOSITORY
.The URL-based ones work as they previously did, while the non-URL ones
are used for repository name-based lookups only.This will require that people update their scripts or
.reviewboardrc
files if passing the old values for the settings, but in the long-run,
it should avoid a lot of problems.
Unit tests pass.
Tested with Subversion (which was the one that broke the most):
--repository-url
worked.--repository-name
worked and did not break the svn info
command..reviewboardrc
options worked.svn switch
to prevent path-based matching and re-did the above tests.Description | From | Last Updated |
---|---|---|
Do we really want to do this kind of breakage in a .z release? |
david |
The repository name is now included properly when doing the post. My previous tests were
still falling back to scanned path-based matching.
Testing Done: |
|
|||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+50 -8) |
docs/rbtools/rbt/commands/diff.txt (Diff revision 2) |
---|
Do we really want to do this kind of breakage in a .z release?
This now targets the 0.6 release.
Branch: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+50 -8) |