post-review: svn wrapper adds inappropriate newlines to some diffs

Review Request #523 — Created Aug. 31, 2008 and submitted


Review Board SVN (deprecated)


Before applying this patch, I was getting diffs (with post-review -n) with doubled-up newlines, like:
--- file1
     (revision 1234)
+++ file1
     (working copy)
(where the leading spaces above are actually tabs)

The RB server rejected these patches on submission.
The problem is that the function parsing the output of 'svn info' was not stripping the trailing newlines.
My internal RB deployment, Ubuntu 8.04 32-bit (client and server); post-review r1477; Subversion command-line client, version 1.5.1. (locally back-ported from Ubuntu Intrepid source package subversion-1.5.1dfsg1).
    1. Actually, looks like this has already been done in another review request, so I'll just commit that. Thanks for the patch though! :)
  2. split doesn't feel like the right thing to me. What we should be doing is rstrip("\n").
    There's a couple of bugs related to newlines. I wonder if we should fix it this way or in a more generic way (say, a flag passed to execute that strips lines).