-
-
rbtools/clients/git.py (Diff revision 1) This doesn't look like it'd work. Shouldn't each of these revisions be a separate argument?
I also just tried
git log ^revision1 revision
and can't get it to do anything but spit back an error. -
Refactor extract_{summary,description} to use parsed revisions.
Review Request #5221 — Created Jan. 8, 2014 and submitted
Refactor
extract_
{summary
,description
} to use parsed revisions.The methods to extract the summary and description (used for guessing the
fields for posting, and for matching open review requests with -u) were using
the old revision range, and were a bit ad-hoc. This cleans them up to always
use the parsed revision spec (except in the case of hgsubversion, which is a
pretty "special" case).
- Ran unit tests
- Posted this change with -g using this code.