• 
      

    Refactor extract_{summary,description} to use parsed revisions.

    Review Request #5221 — Created Jan. 8, 2014 and submitted

    Information

    RBTools
    master

    Reviewers

    Refactor extract_{summary,description} to use parsed revisions.

    The methods to extract the summary and description (used for guessing the
    fields for posting, and for matching open review requests with -u) were using
    the old revision range, and were a bit ad-hoc. This cleans them up to always
    use the parsed revision spec (except in the case of hgsubversion, which is a
    pretty "special" case).

    • Ran unit tests
    • Posted this change with -g using this code.
    Description From Last Updated

    This doesn't look like it'd work. Shouldn't each of these revisions be a separate argument? I also just tried git …

    chipx86chipx86

    Should this be quoted?

    chipx86chipx86
    chipx86
    1. 
        
    2. rbtools/clients/git.py (Diff revision 1)
       
       
      Show all issues

      This doesn't look like it'd work. Shouldn't each of these revisions be a separate argument?

      I also just tried git log ^revision1 revision and can't get it to do anything but spit back an error.

      1. I had fixed this but failed to commit it before posting this change.

    3. rbtools/commands/post.py (Diff revision 1)
       
       
      Show all issues

      Should this be quoted?

    4. 
        
    david
    chipx86
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (b15153f).