Review Request #5220 — Created Jan. 8, 2014 and discarded
This patch introduces more intelligent Mercurial metadata lookup.
Before, the approach was to have rbtools shell out to Mercurial every
time it needed data. This was prone to inefficiencies.In the new world, we have a class that holds all known state about
the Mercurial repository and provides a just-in-time method to resolve
missing metadata on access.Not everything uses the new mechanism yet. But I think this patch
represents a good half-way point from which additional improvements can
be built upon.
Test suite passes.
I added outgoing changeset support to the patch. I also fixed some issues where stderr could interfere with output processing by swallowing stderr during execution and ensuring the environment is sanitized.
Depends On: |
|
||
|---|---|---|---|
Diff: |
Revision 2 (+242 -96) |
| rbtools/clients/mercurial.py (Diff revision 2) |
|---|
This (and the other formats below) seem to assume that the passed-in revision is valid. What happens if the user tries to post with invalid revision identifiers?
| rbtools/clients/mercurial.py (Diff revision 2) |
|---|
Is '0' a valid rev? Should this check
is not Noneexplicitly?
