Cache Mercurial changeset info

Review Request #5220 — Created Jan. 8, 2014 and discarded

indygreg
RBTools
master
5207
rbtools

This patch introduces more intelligent Mercurial metadata lookup.
Before, the approach was to have rbtools shell out to Mercurial every
time it needed data. This was prone to inefficiencies.

In the new world, we have a class that holds all known state about
the Mercurial repository and provides a just-in-time method to resolve
missing metadata on access.

Not everything uses the new mechanism yet. But I think this patch
represents a good half-way point from which additional improvements can
be built upon.

Test suite passes.

Description From Last Updated

Remove this blank line.

daviddavid

This (and the other formats below) seem to assume that the passed-in revision is valid. What happens if the user ...

daviddavid

Is '0' a valid rev? Should this check is not None explicitly?

daviddavid
IN
IN
david
  1. 
      
  2. rbtools/clients/mercurial.py (Diff revision 2)
     
     

    Remove this blank line.

  3. rbtools/clients/mercurial.py (Diff revision 2)
     
     
     
     
     

    This (and the other formats below) seem to assume that the passed-in revision is valid. What happens if the user tries to post with invalid revision identifiers?

  4. rbtools/clients/mercurial.py (Diff revision 2)
     
     

    Is '0' a valid rev? Should this check is not None explicitly?

  5. 
      
IN
  1. This patch has been bit rotted. I'll submit a new version sometime (likely after the parent diff support lands).

  2. 
      
IN
Review request changed

Status: Discarded

Change Summary:

Abandoned.
Loading...